Skip to content

Commit

Permalink
Fix pre-commit configuration to reinstate pylint running (#4258)
Browse files Browse the repository at this point in the history
The `pylint` hook was ignored because the `hook` key in the `local`
category was defined twice. In this case `pre-commit` won't complain
that the file is invalid but the second just overwrites the first
declaration. In addition, the hook was missing the keys `entry`, which
is required, and the `types` key which restricts it to running only on
Python file.
  • Loading branch information
sphuber authored Jul 12, 2020
1 parent 9636ac7 commit 99e608c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ repos:
hooks:
- id: pylint
name: pylint
entry: pylint
types: [python]
language: system
exclude: *exclude_files

hooks:
- id: dm-generate-all
name: Update all requirements files
entry: python ./utils/dependency_management.py generate-all
Expand Down

0 comments on commit 99e608c

Please sign in to comment.