Bump ruff to v0.8.0 (#6634)

Most of the changes here come from a new rule RUF022. Checks for `__all__` definitions that are not ordered according to an "isort-style" sort.
aiidateam · Dec 2, 2024 · 333992b · 333992b
1 parent dbdc36c
commit 333992b
Show file tree

Hide file tree

Showing 62 changed files with 135 additions and 135 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -37,7 +37,7 @@ repos:
     args: [--line-length=120, --fail-on-change]
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.7.3
+  rev: v0.8.0
   hooks:
   - id: ruff-format
   - id: ruff

diff --git a/src/aiida/brokers/rabbitmq/client.py b/src/aiida/brokers/rabbitmq/client.py
@@ -9,7 +9,7 @@
 if t.TYPE_CHECKING:
     import requests
 
-__all__ = ('RabbitmqManagementClient', 'ManagementApiConnectionError')
+__all__ = ('ManagementApiConnectionError', 'RabbitmqManagementClient')
 
 
 class ManagementApiConnectionError(AiidaException):

diff --git a/src/aiida/brokers/rabbitmq/utils.py b/src/aiida/brokers/rabbitmq/utils.py
@@ -2,7 +2,7 @@
 
 from . import defaults
 
-__all__ = ('get_rmq_url', 'get_launch_queue_name', 'get_message_exchange_name', 'get_task_exchange_name')
+__all__ = ('get_launch_queue_name', 'get_message_exchange_name', 'get_rmq_url', 'get_task_exchange_name')
 
 
 def get_rmq_url(protocol=None, username=None, password=None, host=None, port=None, virtual_host=None, **kwargs):

diff --git a/src/aiida/cmdline/params/arguments/__init__.py b/src/aiida/cmdline/params/arguments/__init__.py
@@ -31,14 +31,14 @@
     'NODE',
     'NODES',
     'OUTPUT_FILE',
-    'OverridableArgument',
     'PROCESS',
     'PROCESSES',
     'PROFILE',
     'PROFILES',
     'USER',
     'WORKFLOW',
     'WORKFLOWS',
+    'OverridableArgument',
 )
 
 # fmt: on
diff --git a/src/aiida/cmdline/params/arguments/main.py b/src/aiida/cmdline/params/arguments/main.py
@@ -15,29 +15,29 @@
 from .overridable import OverridableArgument
 
 __all__ = (
-    'PROFILE',
-    'PROFILES',
     'CALCULATION',
     'CALCULATIONS',
     'CODE',
     'CODES',
     'COMPUTER',
     'COMPUTERS',
-    'DATUM',
+    'CONFIG_OPTION',
     'DATA',
+    'DATUM',
     'GROUP',
     'GROUPS',
+    'INPUT_FILE',
+    'LABEL',
     'NODE',
     'NODES',
+    'OUTPUT_FILE',
     'PROCESS',
     'PROCESSES',
+    'PROFILE',
+    'PROFILES',
+    'USER',
     'WORKFLOW',
     'WORKFLOWS',
-    'INPUT_FILE',
-    'OUTPUT_FILE',
-    'LABEL',
-    'USER',
-    'CONFIG_OPTION',
 )
 
 

diff --git a/src/aiida/cmdline/params/options/__init__.py b/src/aiida/cmdline/params/options/__init__.py
@@ -38,8 +38,6 @@
     'COMPUTER',
     'COMPUTERS',
     'CONFIG_FILE',
-    'CallableDefaultOption',
-    'ConfigFileOption',
     'DATA',
     'DATUM',
     'DB_BACKEND',
@@ -69,14 +67,12 @@
     'INPUT_PLUGIN',
     'LABEL',
     'LIMIT',
-    'MultipleValueOption',
     'NODE',
     'NODES',
     'NON_INTERACTIVE',
     'OLDER_THAN',
     'ORDER_BY',
     'ORDER_DIRECTION',
-    'OverridableOption',
     'PAST_DAYS',
     'PAUSED',
     'PORT',
@@ -108,6 +104,10 @@
     'WAIT',
     'WITH_ELEMENTS',
     'WITH_ELEMENTS_EXCLUSIVE',
+    'CallableDefaultOption',
+    'ConfigFileOption',
+    'MultipleValueOption',
+    'OverridableOption',
     'active_process_states',
     'graph_traversal_rules',
     'valid_calc_job_states',

diff --git a/src/aiida/cmdline/params/options/main.py b/src/aiida/cmdline/params/options/main.py
@@ -81,8 +81,8 @@
     'ORDER_BY',
     'ORDER_DIRECTION',
     'OVERWRITE',
-    'PATH',
     'PAST_DAYS',
+    'PATH',
     'PAUSED',
     'PORT',
     'PREPEND_TEXT',

diff --git a/src/aiida/cmdline/params/types/computer.py b/src/aiida/cmdline/params/types/computer.py
@@ -14,7 +14,7 @@
 from ...utils import decorators
 from .identifier import IdentifierParamType
 
-__all__ = ('ComputerParamType', 'ShebangParamType', 'MpirunCommandParamType')
+__all__ = ('ComputerParamType', 'MpirunCommandParamType', 'ShebangParamType')
 
 
 class ComputerParamType(IdentifierParamType):

diff --git a/src/aiida/cmdline/params/types/strings.py b/src/aiida/cmdline/params/types/strings.py
@@ -12,7 +12,7 @@
 
 from click.types import StringParamType
 
-__all__ = ('EmailType', 'EntryPointType', 'HostnameType', 'NonEmptyStringParamType', 'LabelStringType')
+__all__ = ('EmailType', 'EntryPointType', 'HostnameType', 'LabelStringType', 'NonEmptyStringParamType')
 
 
 class NonEmptyStringParamType(StringParamType):

diff --git a/src/aiida/cmdline/utils/decorators.py b/src/aiida/cmdline/utils/decorators.py
@@ -27,7 +27,7 @@
 
 DAEMON_NOT_RUNNING_DEFAULT_MESSAGE = 'daemon is not running'
 
-__all__ = ('with_dbenv', 'dbenv', 'only_if_daemon_running')
+__all__ = ('dbenv', 'only_if_daemon_running', 'with_dbenv')
 
 
 @decorator

diff --git a/src/aiida/cmdline/utils/echo.py b/src/aiida/cmdline/utils/echo.py
@@ -20,14 +20,14 @@
 CMDLINE_LOGGER = logging.getLogger('verdi')
 
 __all__ = (
-    'echo_report',
+    'echo_critical',
+    'echo_dictionary',
+    'echo_error',
     'echo_info',
+    'echo_report',
     'echo_success',
-    'echo_warning',
-    'echo_error',
-    'echo_critical',
     'echo_tabulate',
-    'echo_dictionary',
+    'echo_warning',
 )
 
 

diff --git a/src/aiida/common/__init__.py b/src/aiida/common/__init__.py
@@ -25,6 +25,7 @@
 
 __all__ = (
     'AIIDA_LOGGER',
+    'TQDM_BAR_FORMAT',
     'AiidaException',
     'AttributeDict',
     'CalcInfo',
@@ -74,7 +75,6 @@
     'StashMode',
     'StorageMigrationError',
     'StoringNotAllowed',
-    'TQDM_BAR_FORMAT',
     'TestsNotAllowedError',
     'TransportTaskException',
     'UniquenessError',

diff --git a/src/aiida/common/datastructures.py b/src/aiida/common/datastructures.py
@@ -15,7 +15,7 @@
 
 from .extendeddicts import DefaultFieldsAttributeDict
 
-__all__ = ('StashMode', 'CalcJobState', 'CalcInfo', 'CodeInfo', 'CodeRunMode')
+__all__ = ('CalcInfo', 'CalcJobState', 'CodeInfo', 'CodeRunMode', 'StashMode')
 
 
 class StashMode(Enum):

diff --git a/src/aiida/common/exceptions.py b/src/aiida/common/exceptions.py
@@ -10,48 +10,48 @@
 
 __all__ = (
     'AiidaException',
-    'NotExistent',
-    'NotExistentAttributeError',
-    'NotExistentKeyError',
-    'MultipleObjectsError',
-    'RemoteOperationError',
+    'ClosedStorage',
+    'ConfigurationError',
+    'ConfigurationVersionError',
     'ContentNotExistent',
+    'CorruptStorage',
+    'DbContentError',
+    'EntryPointError',
     'FailedError',
-    'StoringNotAllowed',
-    'ModificationNotAllowed',
+    'FeatureDisabled',
+    'FeatureNotAvailable',
+    'HashingError',
+    'IncompatibleStorageSchema',
+    'InputValidationError',
     'IntegrityError',
-    'UniquenessError',
-    'EntryPointError',
-    'MissingEntryPointError',
-    'MultipleEntryPointError',
-    'LoadingEntryPointError',
+    'InternalError',
     'InvalidEntryPointTypeError',
     'InvalidOperation',
+    'LicensingException',
+    'LoadingEntryPointError',
+    'LockedProfileError',
+    'LockingProfileError',
+    'MissingConfigurationError',
+    'MissingEntryPointError',
+    'ModificationNotAllowed',
+    'MultipleEntryPointError',
+    'MultipleObjectsError',
+    'NotExistent',
+    'NotExistentAttributeError',
+    'NotExistentKeyError',
+    'OutputParsingError',
     'ParsingError',
-    'InternalError',
     'PluginInternalError',
-    'ValidationError',
-    'ConfigurationError',
     'ProfileConfigurationError',
-    'MissingConfigurationError',
-    'ConfigurationVersionError',
-    'IncompatibleStorageSchema',
-    'CorruptStorage',
-    'DbContentError',
-    'InputValidationError',
-    'FeatureNotAvailable',
-    'FeatureDisabled',
-    'LicensingException',
+    'RemoteOperationError',
+    'StorageBackupError',
+    'StorageMigrationError',
+    'StoringNotAllowed',
     'TestsNotAllowedError',
-    'UnsupportedSpeciesError',
     'TransportTaskException',
-    'OutputParsingError',
-    'HashingError',
-    'StorageMigrationError',
-    'StorageBackupError',
-    'LockedProfileError',
-    'LockingProfileError',
-    'ClosedStorage',
+    'UniquenessError',
+    'UnsupportedSpeciesError',
+    'ValidationError',
 )
 
 

diff --git a/src/aiida/common/extendeddicts.py b/src/aiida/common/extendeddicts.py
@@ -12,7 +12,7 @@
 
 from . import exceptions
 
-__all__ = ('AttributeDict', 'FixedFieldsAttributeDict', 'DefaultFieldsAttributeDict')
+__all__ = ('AttributeDict', 'DefaultFieldsAttributeDict', 'FixedFieldsAttributeDict')
 
 
 class AttributeDict(dict):

diff --git a/src/aiida/common/progress_reporter.py b/src/aiida/common/progress_reporter.py
@@ -21,12 +21,12 @@
 from typing import Any, Callable, Optional, Type
 
 __all__ = (
-    'get_progress_reporter',
-    'set_progress_reporter',
-    'set_progress_bar_tqdm',
-    'ProgressReporterAbstract',
     'TQDM_BAR_FORMAT',
+    'ProgressReporterAbstract',
     'create_callback',
+    'get_progress_reporter',
+    'set_progress_bar_tqdm',
+    'set_progress_reporter',
 )
 
 TQDM_BAR_FORMAT = '{desc:40.40}{percentage:6.1f}%|{bar}| {n_fmt}/{total_fmt}'

diff --git a/src/aiida/engine/__init__.py b/src/aiida/engine/__init__.py
@@ -21,6 +21,7 @@
 from .utils import *
 
 __all__ = (
+    'PORT_NAMESPACE_SEPARATOR',
     'AiiDAPersister',
     'Awaitable',
     'AwaitableAction',
@@ -40,7 +41,6 @@
     'JobsList',
     'ObjectLoader',
     'OutputPort',
-    'PORT_NAMESPACE_SEPARATOR',
     'PastException',
     'PortNamespace',
     'Process',

diff --git a/src/aiida/engine/launch.py b/src/aiida/engine/launch.py
@@ -25,7 +25,7 @@
 from .runners import ResultAndPk
 from .utils import instantiate_process, is_process_scoped, prepare_inputs
 
-__all__ = ('run', 'run_get_pk', 'run_get_node', 'submit', 'await_processes')
+__all__ = ('await_processes', 'run', 'run_get_node', 'run_get_pk', 'submit')
 
 TYPE_RUN_PROCESS = t.Union[Process, t.Type[Process], ProcessBuilder]
 # run can also be process function, but it is not clear what type this should be

diff --git a/src/aiida/engine/processes/__init__.py b/src/aiida/engine/processes/__init__.py
@@ -23,6 +23,7 @@
 from .workchains import *
 
 __all__ = (
+    'PORT_NAMESPACE_SEPARATOR',
     'Awaitable',
     'AwaitableAction',
     'AwaitableTarget',
@@ -38,7 +39,6 @@
     'JobManager',
     'JobsList',
     'OutputPort',
-    'PORT_NAMESPACE_SEPARATOR',
     'PortNamespace',
     'Process',
     'ProcessBuilder',

diff --git a/src/aiida/engine/processes/calcjobs/manager.py b/src/aiida/engine/processes/calcjobs/manager.py
@@ -22,7 +22,7 @@
     from aiida.engine.transports import TransportQueue
     from aiida.schedulers.datastructures import JobInfo
 
-__all__ = ('JobsList', 'JobManager')
+__all__ = ('JobManager', 'JobsList')
 
 
 class JobsList:

diff --git a/src/aiida/engine/processes/functions.py b/src/aiida/engine/processes/functions.py
@@ -64,7 +64,7 @@
 if TYPE_CHECKING:
     from .exit_code import ExitCode
 
-__all__ = ('calcfunction', 'workfunction', 'FunctionProcess')
+__all__ = ('FunctionProcess', 'calcfunction', 'workfunction')
 
 LOGGER = logging.getLogger(__name__)
 

diff --git a/src/aiida/engine/processes/ports.py b/src/aiida/engine/processes/ports.py
@@ -22,13 +22,13 @@
 from aiida.orm import Data, Node, to_aiida_type
 
 __all__ = (
-    'PortNamespace',
+    'PORT_NAMESPACE_SEPARATOR',
+    'CalcJobOutputPort',
     'InputPort',
     'OutputPort',
-    'CalcJobOutputPort',
+    'PortNamespace',
     'WithNonDb',
     'WithSerialize',
-    'PORT_NAMESPACE_SEPARATOR',
 )
 
 PORT_NAME_MAX_CONSECUTIVE_UNDERSCORES = 1