XAS: Migrate XAS App to New Repository #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes necessary changes to migrate the XAS app from AiiDAlab-QE to this repository. Additionally fixes two bugs discovered during testing: * Element selection via the tickbox widgets in the XAS settings panel did not work due to a previous change in `aiidalab-qe` which did not return the elements selected to the main workchain. This fix now ensures that both `elements_list` and `core_hole_treatments` are updated correctly for the elements which are selected. * The `spectrum_button` failed to download the spectrum when pressed. The original solution using HTML has been replaced with the Javascript solution used by AiiDAlab-QE for archive downloading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes necessary changes to migrate the XAS app from AiiDAlab-QE to this repository.
Additionally fixes two bugs discovered during testing:
aiidalab-qewhich did not return the elements selected to the main workchain. This fix now ensures that bothelements_listandcore_hole_treatmentsare updated correctly for the elements which are selected.spectrum_buttonfailed to download the spectrum when pressed. The original solution using HTML has been replaced with the Javascript solution used by AiiDAlab-QE for archive downloading.