-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows for relax md runs #85
Workflows for relax md runs #85
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #85 +/- ##
===========================================
- Coverage 85.98% 85.30% -0.69%
===========================================
Files 17 19 +2
Lines 1356 1599 +243
===========================================
+ Hits 1166 1364 +198
- Misses 190 235 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
|
for more information, see https://pre-commit.ci
Here are some basic workchains the user can now use, one basic for relaxation and another one for md runs. I added some basic testing to them and I plan to add documentation in the documentation revamp that I'll do in another PR. Let me know if you think this is okay, or if there be more changes. Cheers |
looking great cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JPchico looks good.
Adding dedicated workflows for structural relaxation via the
minimize
option from lammps and a dedicatedmd
workflow. These should replace what the deprecated calculations did in a more flexible manner. It is still possible to set all kinds of fixes, computes, etc as one would for the base workchain.The underlying base workchain is still controlled via the
parameters
entry port, the difference is that its values are set via dedicated input ports, they are validated to make sure that they make sense in their respective contexts.@chrisjsewell , @sphuber let me know what you think. I still need to add the tests and documentation.