Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows for relax md runs #85

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Jun 13, 2023

Adding dedicated workflows for structural relaxation via the minimize option from lammps and a dedicated md workflow. These should replace what the deprecated calculations did in a more flexible manner. It is still possible to set all kinds of fixes, computes, etc as one would for the base workchain.

The underlying base workchain is still controlled via the parameters entry port, the difference is that its values are set via dedicated input ports, they are validated to make sure that they make sense in their respective contexts.

@chrisjsewell , @sphuber let me know what you think. I still need to add the tests and documentation.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #85 (0e872ec) into develop (5f56b29) will decrease coverage by 0.69%.
The diff coverage is 81.37%.

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
- Coverage    85.98%   85.30%   -0.69%     
===========================================
  Files           17       19       +2     
  Lines         1356     1599     +243     
===========================================
+ Hits          1166     1364     +198     
- Misses         190      235      +45     
Flag Coverage Δ
pytests 85.30% <81.37%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiida_lammps/workflows/md.py 72.00% <72.00%> (ø)
aiida_lammps/workflows/relax.py 85.11% <85.11%> (ø)
aiida_lammps/calculations/base.py 96.62% <100.00%> (ø)

... and 1 file with indirect coverage changes

@JPchico JPchico marked this pull request as ready for review August 28, 2023 06:27
@JPchico
Copy link
Collaborator Author

JPchico commented Aug 28, 2023

@chrisjsewell , @sphuber

Here are some basic workchains the user can now use, one basic for relaxation and another one for md runs. I added some basic testing to them and I plan to add documentation in the documentation revamp that I'll do in another PR.

Let me know if you think this is okay, or if there be more changes.

Cheers

@chrisjsewell
Copy link
Member

looking great cheers

Copy link
Member

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JPchico looks good.

@JPchico JPchico merged commit 77f4594 into aiidaplugins:develop Aug 28, 2023
@JPchico JPchico deleted the workflows-for-relax-md-runs branch August 29, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants