Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unnecessary inputs due to the split between the base and raw parsers and calculations #82

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Jun 7, 2023

This is to remove the inputs that have become redundant due to the splitting of the raw and base parsers and calculations.

@JPchico JPchico added this to the Refactoring and generalization milestone Jun 7, 2023
@JPchico JPchico requested review from chrisjsewell and sphuber June 7, 2023 11:51
@JPchico JPchico self-assigned this Jun 7, 2023
Copy link
Member

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @JPchico

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #82 (5a69516) into develop (a796cae) will decrease coverage by 0.22%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
- Coverage    89.11%   88.90%   -0.22%     
===========================================
  Files           19       19              
  Lines         1461     1451      -10     
===========================================
- Hits          1302     1290      -12     
- Misses         159      161       +2     
Flag Coverage Δ
pytests 88.90% <77.77%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_lammps/parsers/base.py 85.22% <0.00%> (-1.44%) ⬇️
aiida_lammps/calculations/base.py 96.35% <100.00%> (-0.90%) ⬇️

@JPchico JPchico merged commit 2eace50 into aiidaplugins:develop Jun 7, 2023
@JPchico JPchico deleted the 81-remove-unnecessary-inputs-from-the-calculation branch June 12, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants