LAMMPSBaseParser: Fix the parsing of the performance data
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser attempts to extract the measure of the steps per second from
the logfile through a regex to match the following syntax:
Performance: 39.271 ns/day, 0.611 hours/ns, 45452.422 timesteps/s
However, this line can also appear in the form:
Performance: 140354.357 tau/day, 324.894 timesteps/s, 162.447 Matom-step/s
The regex is updated to be indifferent as to the position of the measure
and simply look for the float preceding the `timesteps/s` marker. A test
is added with an example log file with the latter format.
Due to the fixed parsing the reference data of the `test_parser_log`
test was out of date. The test used a manual manner of loading the
reference file and comparing it. This is replaced with the
`data_regression` fixture, which does this automatically and can be used
to automatically update the reference file.
sphuber
force-pushed
the
fix/performance-parsing
branch
from
48c224b to
bbd1c0c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #65 +/- ##
========================================
Coverage 90.24% 90.24%
========================================
Files 32 32
Lines 2439 2439
========================================
Hits 2201 2201
Misses 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser attempts to extract the measure of the steps per second from the logfile through a regex to match the following syntax:
However, this line can also appear in the form:
The regex is updated to be indifferent as to the position of the measure and simply look for the float preceding the
timesteps/smarker. A test is added with an example log file with the latter format.