Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing group functionality #50

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Sep 28, 2022

Small changed to ensure that the group functionality is working. Addresses #32

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #50 (c49691b) into develop (7914049) will increase coverage by 0.16%.
The diff coverage is 40.00%.

@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
+ Coverage    81.83%   81.99%   +0.16%     
===========================================
  Files           30       28       -2     
  Lines         2318     2311       -7     
===========================================
- Hits          1897     1895       -2     
+ Misses         421      416       -5     
Flag Coverage Δ
pytests 81.99% <40.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_lammps/common/input_generator.py 77.18% <40.00%> (-0.32%) ⬇️
aiida_lammps/utils.py
aiida_lammps/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JPchico
Copy link
Collaborator Author

JPchico commented Sep 28, 2022

Hi @chrisjsewell do you think you could give this a quick check? I have locally check that the group functionality is working, I think it was inadvertently broken in some of the changes to the input file generation for the new calculation. Thanks!

@JPchico JPchico merged commit c49691b into aiidaplugins:develop Feb 20, 2023
@JPchico JPchico mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant