-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing an issue in which the arrays names #43
Conversation
…h what AiiDA enforces. For that the `[` and `]` that are usually given by lammps to arrays components are replaces by `__`. Fixes aiidaplugins#42.
for more information, see https://pre-commit.ci
I realized that his had somehow gotten pass me. I wonder how it was working before since it seems to be that the name enforcement is quite old. I notice that the docs are being built always, is that intended @chrisjsewell ? |
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 81.86% 81.88% +0.01%
===========================================
Files 30 30
Lines 2333 2335 +2
===========================================
+ Hits 1910 1912 +2
Misses 423 423
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Heya, If you update your branch, #45 should fix the docs |
…ble array and variables names. Addresses aiidaplugins#43
…le variable name.
Great! It should be fixed now (after some struggling with the reference names). I also changed it so that the trajectories and other outputs follow the same conventions and using the regex as we discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
Fixing an issue in which the arrays names might not be compatible with what AiiDA enforces. For that the
[
and]
that are usually given by lammps to arrays components are replaces by__
. Fixes #42.