Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue in which the arrays names #43

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Jun 10, 2022

Fixing an issue in which the arrays names might not be compatible with what AiiDA enforces. For that the [ and ] that are usually given by lammps to arrays components are replaces by __. Fixes #42.

…h what AiiDA enforces. For that the `[` and `]` that are usually given by lammps to arrays components are replaces by `__`. Fixes aiidaplugins#42.
@JPchico JPchico added the bug label Jun 10, 2022
@JPchico JPchico self-assigned this Jun 10, 2022
@JPchico
Copy link
Collaborator Author

JPchico commented Jun 10, 2022

I realized that his had somehow gotten pass me. I wonder how it was working before since it seems to be that the name enforcement is quite old.

I notice that the docs are being built always, is that intended @chrisjsewell ?

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #43 (c612773) into develop (ee2a009) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    81.86%   81.88%   +0.01%     
===========================================
  Files           30       30              
  Lines         2333     2335       +2     
===========================================
+ Hits          1910     1912       +2     
  Misses         423      423              
Flag Coverage Δ
pytests 81.88% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_lammps/calculations/lammps/base.py 0.00% <0.00%> (ø)
aiida_lammps/common/generate_structure.py 98.07% <ø> (ø)
aiida_lammps/common/input_generator.py 77.50% <100.00%> (+0.07%) ⬆️
aiida_lammps/common/parse_trajectory.py 89.61% <100.00%> (+0.13%) ⬆️
aiida_lammps/common/raw_parsers.py 81.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2a009...c612773. Read the comment docs.

@chrisjsewell
Copy link
Member

Heya, If you update your branch, #45 should fix the docs

@JPchico
Copy link
Collaborator Author

JPchico commented Jun 15, 2022

Great! It should be fixed now (after some struggling with the reference names). I also changed it so that the trajectories and other outputs follow the same conventions and using the regex as we discussed.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants