116 dependabot tests failing for python38

[JPchico]

Fixing an issue in which the newer versions of jsonschema were causing the tests to fail.

Have pinned the jsonschema dependency and removed some leftover python 3.8 tests and mentions.

Fixes #116

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (2e3bfce) to head (6f1458e).

❗ Current head 6f1458e differs from pull request most recent head 1e84f30. Consider uploading reports for the commit 1e84f30 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #119   +/-   ##
========================================
  Coverage    85.51%   85.51%           
========================================
  Files           19       19           
  Lines         1622     1622           
========================================
  Hits          1387     1387           
  Misses         235      235           

Flag	Coverage Δ
pytests	85.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sphuber]

Thanks @JPchico

[sphuber]

I think you can remove all the other backend occurrences. The difference between django/sqlalchemy was removed in AiiDA v2, it no longer makes sense.

[JPchico]

Great! thanks, I suspected it just was not sure why it was there in the latest release.

[sphuber]

If you add this, maybe also add 3.11 to the test matrix of the CI? Also, please update requires-python to be >=3.9. Finally, do you also want to add 3.12 perhaps? aiida-core supports it

[JPchico]

Hi @sphuber !
Thanks for the comments, I wonder if adding the 3.12 is okay since well the plugin supports it but I have not found a lammps release candidate that can be installed with conda for python 3.12 (in general it is a bit of a pain to see which version of lammps is compatible with which python version since the only way seems to look into the conda wheels)

[sphuber]

Does lammps depend on Python?

[JPchico]

Only on the sense on how we install it, we install lammps using conda in the action, and then we use the same python version for aiida. So if we install install python 3.12 there is no lammps conda release for it.
We could install it in some other way, it is possible to do it via apt, but the versioning is a bit unclear there

[JPchico]

Hi @sphuber I'll merge this even if the codecov is failing since this seems to be an upstream issue with the action.