Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Add warnings and errors to the parsing #83

Closed
JPchico opened this issue Jun 8, 2023 · 5 comments
Closed

♻️ Add warnings and errors to the parsing #83

JPchico opened this issue Jun 8, 2023 · 5 comments
Assignees

Comments

@JPchico
Copy link
Collaborator

JPchico commented Jun 8, 2023

Right now the parsing of the lammps output is done via the log file. However, the logfile does not include all the information, as errors and warnings are often not found there. Instead one should use the redirected output from the screen. This output should have all the information of the log file plus the errors and warnings.

The warnings are good to be able to detected minor recoverable problems, and the error is good to be able to detect when and why lammps itself fails.

@JPchico JPchico added this to the Refactoring and generalization milestone Jun 8, 2023
@JPchico JPchico self-assigned this Jun 8, 2023
@JPchico
Copy link
Collaborator Author

JPchico commented Jun 8, 2023

A question @sphuber, the log files that are in the test for the raw parser, are they log files or out files? They look like out files (as I can see some warnings in them).

I'm basically wondering if I can use them for the tests of the "out" file, in principle it should be the same thing as the info of the log file is the same info of the out file minus some parts. but I just want to double check.

@sphuber
Copy link
Member

sphuber commented Jun 8, 2023

I'm basically wondering if I can use them for the tests of the "out" file, in principle it should be the same thing as the info of the log file is the same info of the out file minus some parts. but I just want to double check.

I guess you can remove the log files (if they are there) and if the tests pass, it is all good

@JPchico
Copy link
Collaborator Author

JPchico commented Jun 8, 2023

Sure I'm just wondering since those were the files that you added, and I'm unsure if they are logs or outs. I'm like 75% sure they are outs, and then a simple git mv solves all the issues

@JPchico
Copy link
Collaborator Author

JPchico commented Jun 8, 2023

This also helped me to actually find a bug in how the units were being parsed, so one can be happy for the little things.

JPchico added a commit that referenced this issue Jun 9, 2023
…he log file. (#84)

Changing the parsing of the log to instead use the output printed to screen and redirected to an output file. Fixes #83 
Co-authored-by: Jonathan Chico <jonathan.chico@sandvik.com>
@JPchico
Copy link
Collaborator Author

JPchico commented Jun 12, 2023

Closed via #84

@JPchico JPchico closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants