Add volume information in the cell tab #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 83.47% 83.48%
=======================================
Files 17 17
Lines 3558 3566 +8
=======================================
+ Hits 2970 2977 +7
- Misses 588 589 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aiidalab_widgets_base/viewers.py
Outdated
Comment on lines
717
to
722
| cell_labels = { | ||
| 1: ["length", "Å"], | ||
| 2: ["area", "Ų"], | ||
| 3: ["volume", "ų"], | ||
| } | ||
| cell_label = cell_labels.get(dimension_data["dim"]) |
There was a problem hiding this comment.
Consider defining CELL_LABELS outside to avoid redefining them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #652 .
Add volume information in the cell tab, the text depends on the periodic boundary condtion.
As suggested by @cpignedoli , we use the function from
orm.StructureDatadirectly. Note, the cell tab is inside class_StructureDataBaseViewer, which usesase.Atomsto store the structure, so we can not useStructureData.get_dimensionalitydirectly, but use the private function_get_dimensionality. Even though it's a private function, I decided to use it so we get updated in the future automatically and do not re-write duplicate code.