Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins.yaml #885

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update plugins.yaml #885

merged 2 commits into from
Oct 23, 2024

Conversation

mikibonacci
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (e08d490) to head (7dab19d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files          51       51           
  Lines        4707     4707           
=======================================
  Hits         3161     3161           
  Misses       1546     1546
Flag Coverage Δ
python-3.11 67.15% <ø> (ø)
python-3.9 67.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

superstar54
superstar54 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I suggest using ~, so that it allows patch updates within 1.1.x series

plugins.yaml Outdated Show resolved Hide resolved
@mikibonacci @superstar54
Update plugins.yaml
7dab19d 
Co-authored-by: Xing Wang <xingwang1991@gmail.com>
@mikibonacci mikibonacci merged commit 30ea955 into main Oct 23, 2024
10 of 11 checks passed
@mikibonacci mikibonacci deleted the mikibonacci-patch-1 branch October 23, 2024 07:40
edan-bainglass pushed a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
@mikibonacci @superstar54 @edan-bainglass
Update plugins.yaml (aiidalab#885)
166f942 
* Update plugins.yaml

* Update plugins.yaml

Co-authored-by: Xing Wang <xingwang1991@gmail.com>

---------

Co-authored-by: Xing Wang <xingwang1991@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superstar54 superstar54 superstar54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikibonacci @superstar54