changing guide button label and layout #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 50 50
Lines 4598 4598
=======================================
Hits 3114 3114
Misses 1484 1484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superstar54
reviewed
Oct 9, 2024
src/aiidalab_qe/app/wrapper.py
Outdated
| tooltip="Learn how to use the app", | ||
| disabled=True, | ||
| layout=ipw.Layout(width="50%"), |
There was a problem hiding this comment.
The width will depend on the parent container. Since the number of text is fixed, we maybe use an absolute value. e.g, 150px. Please try to determine which value is best.
|
|
edan-bainglass
added a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR modifies the description of the guide toggle button