Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim image without fix-permissions on CONDA_DIR #790

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jul 31, 2024

see #789

@unkcpz unkcpz mentioned this pull request Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (94b92f3) to head (ab5b2bc).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          45       45           
  Lines        4148     4148           
=======================================
  Hits         2830     2830           
  Misses       1318     1318           
Flag Coverage Δ
python-3.10 68.22% <ø> (ø)
python-3.9 68.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz requested a review from danielhollas July 31, 2024 12:48
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works let's go for it! In particular, could you test that you can still run conda install and pip install --no-user into the base environment?

I've opened aiidalab/aiidalab-docker-stack#486 for follow-up on aiidalab-docker-stack. Perhaps there are wins to be had there as well!

@unkcpz
Copy link
Member Author

unkcpz commented Jul 31, 2024

could you test that you can still run conda install and pip install --no-user into the base environment?

Yes, I can run them without problem.

@unkcpz unkcpz merged commit ea6b645 into main Jul 31, 2024
12 checks passed
@unkcpz unkcpz deleted the slim-usable-image-question-mark branch July 31, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants