-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize static
folder and add pre-loaded stylesheets
#772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 68.16% 68.16%
=======================================
Files 48 48
Lines 4159 4159
=======================================
Hits 2835 2835
Misses 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2b87418
to
602fcc4
Compare
cfe8b07
to
50e5d19
Compare
46f59f8
to
24c7d66
Compare
@danielhollas, @superstar54, @yakutovicha the silicon select and confirm test is timing out. I tried to commit an increase to the timeout (to 60s), but it still is not enough. I'm surprised the new CSS loading or the reorganization of static files could cause such a delay. Could someone please give it a look? |
c96aa92
to
c78336d
Compare
Resolved. Thanks @superstar54 🙂 |
58e7eab
to
d54b487
Compare
d54b487
to
3465960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, only one comment about the outdated README file. Leaving approval to others.
This PR reorganizes the static folder with dedicated subfolders for templates and styles. The styles folder holds stylesheets that are automatically loaded (using a new
aiidalab-widgets-base
utility function) in the main notebook.Dependency
This PR depends on aiidalab/aiidalab-widgets-base#624, which introduces the
load_css
utility