Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting the diamond.cif file #757

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

mikibonacci
Copy link
Member

@mikibonacci mikibonacci commented Jun 29, 2024

This will give case-insensitive problems with Diamond.cif - this will happen only for case-insensitive filesystems like my Mac. The problem is that then is it not possible to clone the repo without having to choose (git does it) among the two files.

The diamond.cif file seems anyway not used, so we do not need it.

This will solve #756.

problems with Diamond.cif - this will happen only for case-insensitive
filesystems.
@mikibonacci mikibonacci requested a review from unkcpz June 29, 2024 21:52
@superstar54 superstar54 self-requested a review June 30, 2024 07:17
@superstar54
Copy link
Member

superstar54 commented Jun 30, 2024

Hi @mikibonacci , thanks for the fix!

The test failed because of the wrong setup.cfg in one of the dependence aiidalab-eln. I made a PR to aiidalab-eln to fix it.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (39d411b) to head (46cf7fe).
Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   68.28%   68.28%           
=======================================
  Files          45       45           
  Lines        4143     4143           
=======================================
  Hits         2829     2829           
  Misses       1314     1314           
Flag Coverage Δ
python-3.10 68.28% <ø> (ø)
python-3.9 68.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit e2d3d93 into aiidalab:main Jul 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants