fix setting default codes #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
requested changes
Apr 29, 2024
| code.value = orm.load_code(DEFAULT_PARAMETERS["codes"][name]).uuid | ||
| except NotExistent: | ||
| pass | ||
| self.set_selected_codes(DEFAULT_PARAMETERS["codes"]) |
There was a problem hiding this comment.
Is set_seleceted_codes method accept None? If the code setup is not success (rarely but possible), will this raise an error? You can test by remove the code and see if this change still works.
There was a problem hiding this comment.
Thanks for the review. Yes, the set_seleceted_codes can handle None.
I tested as you suggested, I deleted the code, and it works.
unkcpz
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #698
Now the codes are automatically set to default ones if available
qeapp-auto-set-codes.mp4