Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HP code and LiCoO2 example #655

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

superstar54
Copy link
Member

No description provided.

@superstar54
Copy link
Member Author

Already added in #650

@superstar54 superstar54 closed this Apr 2, 2024
@superstar54 superstar54 reopened this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (df1b7cf) to head (1968684).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files          60       60           
  Lines        4319     4319           
=======================================
  Hits         3271     3271           
  Misses       1048     1048           
Flag Coverage Δ
python-3.10 75.73% <ø> (ø)
python-3.9 75.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member Author

We may not add the aiidalab-qe-hp plugin to the core and keep it as a separate plugin. So #650 needs to be split. We first add the hp code in this PR. This is the first step to implementing the aiidalab-qe-hp.

@superstar54 superstar54 merged commit 97c9c10 into aiidalab:main Apr 3, 2024
15 checks passed
@superstar54 superstar54 deleted the feature/add_hp_code branch April 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant