-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin list page #646
Add plugin list page #646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 75.50% 75.47% -0.03%
==========================================
Files 60 60
Lines 4401 4404 +3
==========================================
+ Hits 3323 3324 +1
- Misses 1078 1080 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
433a852
to
9c002e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I will not have time to review this fully.
My only quick thought is that this seem overengineered and will be yet another thing to maintain. Do we really need another registry just for the QeApp? How about simply having a static yaml file in this repo?
Good point. For the QE App, we don't really need a separate repo like AiiDAlab and AiiDA. |
@danielhollas I moved the yaml file into this repository. |
@danielhollas @unkcpz, any further comment on this PR? If not, I will merge it to be included in the next release. It is important that users can discover the plugins through this, e.g., @mikibonacci 's plugins. Since this belongs to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to do full review and as I am not an active user/developer of QeApp it's not my place. Hopefully @unkcpz has time to chime in.
Nevertheless, this looks cool and interesting. Thanks for moving the YAML config here.
@mikibonacci feel free to modify the |
Hi all, if there are no more comments, I will merge this PR by the end of the day. |
We foresee more plugins coming, and they may be developed by other developers and in other repositories. To help users easily find and manage the plugins, this PR adds a new plugin list page.
Plugin registry
User can add their plugin entry point into the
plugins.yaml
file in this repository.Home page
On the home page, I added a new Preference section on the right side of the logo. For the moment, there is only the
plugin list
item, but we can add more user preference items in the future.Plugin list page
The UI has the following features:
Despite the
AppStore
's extensive features, I opted against using it due to its complexity and lack of fit for this specific application.Demo
qeapp-plugin-list-page.mp4
Future improvement
After this PR, open issues on
Update
button.