Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate py3.8 where AWB already deprecated it #633

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 12, 2024

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (1157b88) to head (eabfdf0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   75.79%   75.79%           
=======================================
  Files          60       60           
  Lines        4300     4300           
=======================================
  Hits         3259     3259           
  Misses       1041     1041           
Flag Coverage Δ
python-3.10 75.79% <ø> (ø)
python-3.8 ?
python-3.9 75.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@unkcpz unkcpz merged commit d77bdb2 into aiidalab:main Mar 12, 2024
13 checks passed
@unkcpz unkcpz deleted the deprecate-py3.8 branch March 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants