Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: temporarily disable pre commit #219

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 30, 2022

As described in #206 (comment), the ci test failed since an installation issue. Temporarily disabled it and enable it after it is fixed on pre-commit side. Pining virtualenv version to workaround, which needs to be removed after issue fixed.

@unkcpz unkcpz force-pushed the ci/temprarily-disable-pre-commit branch from 4e1a7f0 to 1630a15 Compare March 30, 2022 07:28
@unkcpz unkcpz requested a review from csadorf March 30, 2022 07:28
Copy link
Member

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not do what is described in the PR description and also does not work unfortunately.

@unkcpz unkcpz force-pushed the ci/temprarily-disable-pre-commit branch from 1630a15 to 12fceb4 Compare March 30, 2022 07:54
- Remove workaround, after problem described in #206 (comment)
 is resolved.
- new psf/black version for issue psf/black#2964 (comment)
@unkcpz unkcpz force-pushed the ci/temprarily-disable-pre-commit branch from 12fceb4 to 2be1c0e Compare March 30, 2022 07:59
@unkcpz
Copy link
Member Author

unkcpz commented Mar 30, 2022

@csadorf Sorry, yes, it was failed, sadly. I didn't comment the pre-commit part out since Format YAML files pre-commit will wipe out all comments if the yaml file is empty. Instead, I use the workaround mentioned at ContinuumIO/anaconda-issues#12094 (comment). The pre-commit was then failed since the psl/black version issue. Also fixed here.

@unkcpz unkcpz requested a review from csadorf March 30, 2022 08:15
@unkcpz unkcpz merged commit 44bed09 into master Mar 30, 2022
@unkcpz unkcpz deleted the ci/temprarily-disable-pre-commit branch March 30, 2022 08:22
@unkcpz
Copy link
Member Author

unkcpz commented Mar 30, 2022

@csadorf thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants