Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status panel behavior #1166

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Feb 17, 2025

This PR updates the status panel as follows:

  1. The root node of the process tree is force selected to avoid inconsistent selection on process node loading
  2. metadata_inputs keys not found in root workflow properties are ignored
  3. Dynamic marking (*) propagates upwards (legend updated to better reflect meaning)

Resolves #1108

@edan-bainglass
Copy link
Member Author

@superstar54 @mikibonacci I tried to reproduce the duplicate-node issue on the new laptop. No luck!

Tried:

  • Si2 unrelaxed + pdos
  • Si2 fully relaxed + pdos + fat bands

I'll check in person later what you guys are running and we can discuss.

@superstar54
Copy link
Member

@edan-bainglass thanks for hte work. It looks like this PR is not related to #1162 . Could you remove the unrelated code? Keeping the PR focused will make the review process smoother.

@edan-bainglass
Copy link
Member Author

@superstar54 please review #1162 first, then I'll rebase 🙏 If you wish to review this one first, simply ignore the first file 🙂 The rest of the changes are relevant to this PR.

@edan-bainglass
Copy link
Member Author

I'll fix the tests in a bit

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.99%. Comparing base (b2a7210) to head (291e34f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   72.99%   72.99%           
=======================================
  Files          94       94           
  Lines        6524     6532    +8     
=======================================
+ Hits         4762     4768    +6     
- Misses       1762     1764    +2     
Flag Coverage Δ
python-3.11 72.99% <100.00%> (+<0.01%) ⬆️
python-3.9 73.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the fix-simplified-tree branch 3 times, most recently from 1a628d1 to 39b2f20 Compare February 17, 2025 13:22
@edan-bainglass
Copy link
Member Author

@superstar54 please give it another look 🙏

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the added comment.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edan-bainglass edan-bainglass merged commit 511b3a0 into aiidalab:main Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the status of the workflow, also the sum should have a star if the sub-workflows have a star?
2 participants