-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve status panel behavior #1166
Improve status panel behavior #1166
Conversation
@superstar54 @mikibonacci I tried to reproduce the duplicate-node issue on the new laptop. No luck! Tried:
I'll check in person later what you guys are running and we can discuss. |
c882f50
to
395045b
Compare
@edan-bainglass thanks for hte work. It looks like this PR is not related to #1162 . Could you remove the unrelated code? Keeping the PR focused will make the review process smoother. |
@superstar54 please review #1162 first, then I'll rebase 🙏 If you wish to review this one first, simply ignore the first file 🙂 The rest of the changes are relevant to this PR. |
I'll fix the tests in a bit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
=======================================
Coverage 72.99% 72.99%
=======================================
Files 94 94
Lines 6524 6532 +8
=======================================
+ Hits 4762 4768 +6
- Misses 1762 1764 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1a628d1
to
39b2f20
Compare
39b2f20
to
88d2053
Compare
@superstar54 please give it another look 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the added comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the status panel as follows:
metadata_inputs
keys not found in root workflowproperties
are ignoredResolves #1108