Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conda activattion from opt/prepare-aiidalab.sh script. #46

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

yakutovicha
Copy link
Member

Fixes #39

To merge after aiidateam/aiida-core#3791

@yakutovicha
Copy link
Member Author

I believe the tests will fail because aiidateam/aiida-core#3791 is not yet merged.

@yakutovicha yakutovicha requested a review from ltalirz February 23, 2020 13:52
@yakutovicha
Copy link
Member Author

I believe the tests will fail because aiidateam/aiida-core#3791 is not yet merged.

Failed as expected.

Before merging one just needs to re-run the tests.

@yakutovicha yakutovicha merged commit bcc06a5 into develop Feb 24, 2020
@yakutovicha yakutovicha deleted the conda_activation branch February 24, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to avoid copying conda activation scripts from .bashrc
1 participant