Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rwinlib ucrt binaries #82

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix for rwinlib ucrt binaries #82

merged 1 commit into from
Jul 27, 2021

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jul 26, 2021

Hello I maintain the rwinlib binaries.

Here is a small tweak needed for compatibility with the new ucrt compilers, see upstream: jeroen/curl@5226cd8

@sa501428
Copy link
Member

@cwenger does this seem ok?

Copy link
Collaborator

@cwenger cwenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @jeroen thanks so much for taking the time to do a PR for us!

@jeroen
Copy link
Contributor Author

jeroen commented Jul 27, 2021

No problem

@cwenger cwenger merged commit 7195dbc into aidenlab:master Jul 27, 2021
@jeroen
Copy link
Contributor Author

jeroen commented Jul 27, 2021

Could you release this to CRAN one of these days? Thanks!

@cwenger
Copy link
Collaborator

cwenger commented Jul 27, 2021

Sure, will do!

@cwenger
Copy link
Collaborator

cwenger commented Sep 18, 2021

@jeroen Just FYI, a few days ago we released an update to CRAN which included this change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants