Automated GitHub Actions Test for gRPC Training #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremblerz
requested changes
Dec 1, 2024
.vscode/settings.json
Outdated
| "python.analysis.typeCheckingMode": "strict", | ||
| "sshfs.configs": [ |
src/configs/sys_config.py
Outdated
| @@ -158,16 +158,20 @@ def get_digit_five_support(num_users: int, domains: List[str] = DIGIT_FIVE): | |||
| CIAR10_DPATH = "./datasets/imgs/cifar10/" | |||
|
|
|||
| NUM_COLLABORATORS = 1 | |||
| DUMP_DIR = "/mas/camera/Experiments/SONAR/abhi/" | |||
| # DUMP_DIR = "../../../../../../../home/" | |||
| DUMP_DIR = "./" | |||
There was a problem hiding this comment.
Let's make the default dump directory as /tmp
The risk with keeping "./" as dump directory is that the dump_dir might try to copy itself in dump_dir kicking off a recursive cascade
src/configs/sys_config.py
Outdated
| "num_collaborators": NUM_COLLABORATORS, | ||
| "dset": CIFAR10_DSET, | ||
| "dump_dir": DUMP_DIR, | ||
| "dpath": CIAR10_DPATH, | ||
| "seed": 32, | ||
| # "seed": 32, |
There was a problem hiding this comment.
make sure to not include any unnecessary comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the ability to automate testing of gRPC training whenever new changes are being made to the repo. You can change the configuration of the test using algo_config_test.py and sys_config_test.py (do not alter the DUMP_DIR). You can add/change the algorithms as well as number of rounds and samples for testing in GitHub actions. This test ensures that new code being pushed does not break existing working functionality. Changes in send_quorum have been made to ensure the tests work in a Linux environment.
NOTE: This PR includes code from the MPI PR.