Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #143

Closed
wants to merge 14 commits into from
Closed

Logging #143

wants to merge 14 commits into from

Conversation

aymann121
Copy link
Contributor

Edited Log_utils file to create global graph cvs files and adjacency matricies

Edited plot_utils file to create 3 visualizations based on log_util output files, created a heatmap of node connections, a video of connection progressions throughout rounds and a weighted graphs depicting how often each edge is utilized.

image
image
image

@@ -339,6 +339,13 @@ def log_metrics(self, stats: Dict[str, Any], iteration: int) -> None:
imgs=stats["images"], key="sample_images", iteration=iteration
)

#config["num_users"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is the logic to log a graph at every round or only do it in a posthoc manner (in the plot utils) where we log the graph in the end? I am seeing code in both log_utils and plot_utils so not sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic is the log the global csv files for each round of each node. Once the final node of a round finishes, the plotter will work to plot the results of that round based on the data produced by the logger.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But csv files were already getting logged about who is collaborating with whom at every round, why store separate csv files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, there isn't any information that needs to be captured in addition to what we were already capturing for generating the three network visualizations (post training), correct?

@tremblerz
Copy link
Contributor

Based on today's discussion, two remaining tasks -

  • Fix the double arrow edges to separate edges.
  • All the code should be in post_hoc plot_utils

@aymann121 aymann121 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants