Log communication cost #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not GRPC's interceptor? |
|
It is doing the same thing, so this was just easier and more intuitive. grpc interceptor on the requestor's end is gonna have the same lines of code. On the sender's end, it still makes sense, but having a similar structure on both ends makes more sense. |
|
Also, given the structure of the algorithms, after each round, only the received communication cost will be reliable because of asynchrony. |
|
Tested with |
tremblerz
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt at logging the up and down communication costs in GRPC. A decorator on the sender's end and inside callback_fn at the receiver.