Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to define "basePath" #111

Closed
vykozlov opened this issue Apr 18, 2023 · 1 comment · Fixed by #145 or #140 · May be fixed by #171
Closed

Ability to define "basePath" #111

vykozlov opened this issue Apr 18, 2023 · 1 comment · Fixed by #145 or #140 · May be fixed by #171
Assignees
@alvarolopez
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
3.0.0 - Improve m...

Comments

@vykozlov
Copy link
Contributor

vykozlov commented Apr 18, 2023 •
edited
Loading

Description

Sometimes, especially when behind the reverse proxy, it might be useful to have "basePath" for the API not as / but as something else, e.g /api. It would be nice, if a user could (re-)define this "basePath"

In the case of OAS3, in swagger.yaml this would correspond to:

servers:
  - url: /api

Ref: https://swagger.io/docs/specification/api-host-and-base-path/
@vykozlov vykozlov added the enhancement New feature or request label Apr 18, 2023
@alvarolopez alvarolopez added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 21, 2023
alvarolopez added a commit that referenced this issue Mar 19, 2024
@alvarolopez
feat: add ability to setup base path to serve the API from a custom path
dcfcbce 
Fixes #111
@alvarolopez alvarolopez self-assigned this Mar 19, 2024
alvarolopez added a commit that referenced this issue Mar 19, 2024
@alvarolopez
feat: add ability to setup base path to serve the API from a custom path
d80d248 
Fixes #111
alvarolopez added a commit that referenced this issue Mar 19, 2024
@alvarolopez
feat: add ability to setup base path to serve the API from a custom path
286183a 
Fixes #111
@alvarolopez alvarolopez mentioned this issue Mar 19, 2024
Merged
alvarolopez added a commit that referenced this issue Mar 19, 2024
@alvarolopez
feat: add ability to setup base path to serve the API from a custom path
6b7874a 
Fixes #111
@alvarolopez alvarolopez mentioned this issue Mar 19, 2024
Merged
@alvarolopez alvarolopez reopened this Jun 11, 2024
@alvarolopez
Copy link
Collaborator

This is not working, as only the UI is being mounted under the new path.

alvarolopez added a commit that referenced this issue Jun 11, 2024
@alvarolopez
fix: allow users to setup base_path for serving under a different prefix
ead08f7 
Fixes #111
alvarolopez added a commit that referenced this issue Jun 11, 2024
@alvarolopez
fix: allow users to setup base_path for serving under a different prefix
1edcdaa 
Fixes #111
alvarolopez added a commit that referenced this issue Jun 11, 2024
@alvarolopez
fix: allow users to setup base_path for serving under a different prefix
3f465fb 
Fixes #111
@ai4-bot ai4-bot mentioned this issue Jun 12, 2024
Open
alvarolopez added a commit that referenced this issue Aug 8, 2024
@alvarolopez
fix: allow users to setup base_path for serving under a different prefix
55a3fec 
Fixes #111
@alvarolopez alvarolopez mentioned this issue Aug 8, 2024
Merged
alvarolopez added a commit that referenced this issue Aug 8, 2024
@alvarolopez
fix: allow users to setup base_path for serving under a different prefix
39fa910 
Fixes #111
@ai4-bot ai4-bot mentioned this issue Aug 6, 2024
Merged
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: do not pass basePath to aiohttp_apispec
3a368d2 
Passing the basePath to the aiohttp_apispec.setup_aiohttp_apispec method
caused that URL that were used from the Swagger UI added the path twice,
resulting in 404 not found methods.

Fixes #111
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: do not pass basePath to aiohttp_apispec
22dcae9 
Passing the basePath to the aiohttp_apispec.setup_aiohttp_apispec method
caused that URL that were used from the Swagger UI added the path twice,
resulting in 404 not found methods.

Fixes #111
@alvarolopez alvarolopez mentioned this issue Aug 9, 2024
Merged
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: also serve static_path from base_path
372c1ba 
Fixes #111
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: also serve static_path from base_path
36574e0 
Fixes #111
IgnacioHeredia pushed a commit that referenced this issue Aug 9, 2024
@alvarolopez @IgnacioHeredia
fix: do not pass basePath to aiohttp_apispec
45c8452 
Passing the basePath to the aiohttp_apispec.setup_aiohttp_apispec method
caused that URL that were used from the Swagger UI added the path twice,
resulting in 404 not found methods.

Fixes #111
IgnacioHeredia pushed a commit that referenced this issue Aug 9, 2024
@alvarolopez @IgnacioHeredia
fix: also serve static_path from base_path
267ab6a 
Fixes #111
@ai4-bot ai4-bot mentioned this issue Aug 9, 2024
Merged
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: do not pass basePath to aiohttp_apispec
82a18f2 
Passing the basePath to the aiohttp_apispec.setup_aiohttp_apispec method
caused that URL that were used from the Swagger UI added the path twice,
resulting in 404 not found methods.

Fixes #111
alvarolopez added a commit that referenced this issue Aug 9, 2024
@alvarolopez
fix: also serve static_path from base_path
c30db00 
Fixes #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarolopez alvarolopez

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
3.0.0 - Improve model loading
2 participants
@alvarolopez @vykozlov