Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final open-sourcing todos #986

Closed
wants to merge 9 commits into from
Closed

Final open-sourcing todos #986

wants to merge 9 commits into from

Conversation

nbren12
Copy link
Contributor

@nbren12 nbren12 commented Feb 5, 2021 •
edited
Loading

Some final cleanups before open sourcing fv3net.

Resolves #920

@spencerkclark
Copy link
Member

This weekend I discovered another issue related to using the latest version of cftime with xarray: pydata/xarray#4870. I quickly wrote / merged a fix: pydata/xarray#4871, but currently that's only in the master version (i.e. it hasn't been released yet). Should I inquire about making a new xarray release? It has been a little more than two months since the last one.

@nbren12
Copy link
Contributor Author

nbren12 commented Feb 8, 2021

@spencerkclark Yah it might be worth making a new release.

@spencerkclark
Copy link
Member

Discussion has started in xarray regarding a 0.17.0 release: pydata/xarray#4894. It should hopefully happen soon after a few more open PRs are merged.

@nbren12 nbren12 changed the title Fv3net licensing Final open-sourcing todos Feb 25, 2021
@spencerkclark
Copy link
Member

All good on the xarray front now: https://github.com/pydata/xarray/releases/tag/v0.17.0.

@nbren12 nbren12 mentioned this pull request Feb 26, 2021
Closed
oliverwm1
oliverwm1 reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@oliverwm1 oliverwm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just resolved conflicts with master. This looks good to me except it looks like a submodule update got wrapped in somehow?

@nbren12
Copy link
Contributor Author

nbren12 commented Mar 8, 2021

I just haven't been able to figure out why the unit tests keep failing.

@nbren12
Copy link
Contributor Author

nbren12 commented Mar 9, 2021

Xarray 0.17 only supports python 3.7+ https://github.com/pydata/xarray/blob/50d97e9d35bac783850827fa66ff5eb768e62905/setup.cfg#L67.

@nbren12 nbren12 mentioned this pull request Mar 17, 2021
Merged
@nbren12
Copy link
Contributor Author

nbren12 commented Mar 17, 2021

Closed in favor of #1090.

@nbren12 nbren12 closed this Mar 17, 2021
@nbren12 nbren12 deleted the fv3net-licensing branch March 17, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverwm1 oliverwm1 oliverwm1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public release of fv3net
3 participants
@nbren12 @spencerkclark @oliverwm1