Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ESM build for React Native, fix RN test #2

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Use ESM build for React Native, fix RN test #2

merged 2 commits into from
Mar 22, 2020

Conversation

farwayer
Copy link
Contributor

@farwayer farwayer commented Mar 22, 2020 •
edited
Loading

I didn't remove .cjs.js generation. It may be useful for envs that do not understand .cjs extension and consider file.cjs as filename.

@farwayer farwayer mentioned this pull request Mar 22, 2020
Closed
@ai
Copy link
Owner

ai commented Mar 22, 2020

Wow. Awesome.

Do we need to ask all RN users to use metro-react-native-babel-transformer?

@farwayer
Copy link
Contributor Author

Nope, React Native projects already have all necessary configuration. We need it here just because we do not use react-native tools.

@ai ai merged commit 775c5e3 into ai:master Mar 22, 2020
@farwayer farwayer deleted the rn-esm branch March 23, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farwayer @ai