Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gist Support #608

Closed
ahmedkaludi opened this issue Feb 22, 2017 · 4 comments
Closed

Gist Support #608

ahmedkaludi opened this issue Feb 22, 2017 · 4 comments
Assignees
@MARQAS
Milestone
0.9.51

Comments

@ahmedkaludi
Copy link
Owner

ampproject/amphtml#829
ampproject/amp-by-example#90
@ahmedkaludi ahmedkaludi changed the title Gist Support in AMP Gist Support Feb 22, 2017
@ahmedkaludi ahmedkaludi added this to the Features < To-Do Tasks milestone Feb 22, 2017
@MARQAS
Copy link
Contributor

MARQAS commented May 12, 2017

https://ampbyexample.com/components/amp-gist/

@ahmedkaludi
Copy link
Owner Author

Wow @MARQAS Good Job on this finding! We must have this!

@MARQAS MARQAS self-assigned this May 13, 2017
@ahmedkaludi ahmedkaludi removed this from the 0.9.50 milestone May 24, 2017
@MARQAS MARQAS assigned MARQAS and unassigned MohammedKaludi May 31, 2017
@MARQAS MARQAS added this to the 0.9.51 milestone May 31, 2017
MARQAS added a commit that referenced this issue May 31, 2017
@MARQAS
Gist Support added #608
fea8cbc 
Just add the shortcode and enjoy devs
@MARQAS
Copy link
Contributor

MARQAS commented May 31, 2017

Just add a shortcode and enjoy Devs (Ex: [amp-gist id="b9bb35bc68df68259af94430f012425f"] )

@MohammedKaludi
Copy link
Collaborator

Tested and code is working nicely, but need to convert it as Gist Sanitizer in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MARQAS MARQAS

Labels
None yet
Projects
None yet
Milestone
0.9.51
Development

No branches or pull requests
3 participants
@MARQAS @ahmedkaludi @MohammedKaludi