Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time signature changes does not get saved on .midi file #111

Open
alejg opened this issue Jun 5, 2023 · 7 comments
Open

Time signature changes does not get saved on .midi file #111

alejg opened this issue Jun 5, 2023 · 7 comments

Comments

@alejg
Copy link

alejg commented Jun 5, 2023

Steps to reproduce (please see attached video):

  • create various 4/4 patterns
  • change one to 3/4
  • save midi file
  • close qseq66 and open the midi file
    expected: see the same polyrhythm I've saved
Captura.del.escritorio.de.05-06-23.18.05.51.webm

Thanks!

@ahlstromcj
Copy link
Owner

ahlstromcj commented Jun 5, 2023 via email

@alejg
Copy link
Author

alejg commented Jun 6, 2023

muchas gracias!

@ahlstromcj
Copy link
Owner

I worked this out and went well beyond fixing the bug; time-signatures are now supported in the pattern editor and the event editor. There are probably still some minor nagging issues to work out, but later. Along with the fixes to issue #111, the new version 0.99.6 should come out this weekend.

@mxmilkiib
Copy link

A reminder of the case of certain folk (and elecronic dance) music times signatures like 17/8 ahlstromcj/sequencer64#181

https://en.wikipedia.org/wiki/Music_of_Bulgaria#Asymmetric_meters

@alejg
Copy link
Author

alejg commented Jun 29, 2023

Awsome work!!! i'll check it when released!
thanks!!!

@ahlstromcj
Copy link
Owner

ahlstromcj commented Jun 30, 2023 via email

ahlstromcj added a commit that referenced this issue Jul 1, 2023
This file lists __major__ changes from version 0.99.6

    -   Issue #3 follow-ons:
        -   Pattern editor panes stay in sync with the piano roll using
            the hjkl, arrow, and page keys. Scroll wheel works in
            the piano roll.
    -   Issue #110 follow-ons:
        -   Addition of Start menu entries for Windows.
        -   Fixed access to the tutorial and manual.
        -   data/readme & doc/tutorial files fixed for NSIS installer.
        -   Fixed the saving of modified tempo changes.
        -   Fixed changing note velocities in the pattern editor data
            pane.  Improved velocity-change undo.
        -   Fixed error preventing changing the "background" pattern.
        -   Remaining issue: Building 32-bit (Windows XP) version on
            64-bit Windows.
    -   Issue #111:
        -   Added support for editing, storing, and displaying time
            signatures in the pattern and event editors.
        -   The first time-signature in a pattern becomes the main
            time signature of the pattern.
        -   The data pane shows a time-signature as a simple fraction.
        -   Changing the time signature if at time 0 is automatic.
        -   Time signatures at later times are logged by setting the
            current time with a click in the top half of the time line,
            changing the beats and beat width, then clicking a
            time-sig log button.
        -   Non-MIDI-standard beat-widths are supported as a
            Seq66-specific "event".
        -   Fixed event filtering in the event (qstriggereditor) pane.
        -   As time-signatures change, Seq66 adjusts the piano roll,
            time line (with measure counts), and event pane vertical
            lines.
    -   Port-mapping prompts about port issues and allows an immediate
        remap-and-restart.
    -   'o' keystroke in seqroll toggles recording ('r' already
        taken).
    -   Added a "quiet" option to not show startup message prompts.
    -   A log-file is now created by default & kept under a megabyte.
    -   Added the pattern port number to the Song Summary output.
    -   A large number of fixes of unrelated issues.

Read the NEWS, README.md, and TODO files.  Working our assoff!

// vim: sw=4 ts=4 wm=15 et ft=sh
@ahlstromcj
Copy link
Owner

Latest release 0.99.6 in place in master branch for you to whack at! User manual updated to match.

ahlstromcj added a commit that referenced this issue Jul 5, 2023
ahlstromcj added a commit that referenced this issue Jul 19, 2023
This file lists __major__ changes in version 0.99.7
    -   Issue #110 follow-ons:
        -   Fixed saving tempo (BPM) in Windows when changed from main
            window. Caused by mixing a long and size_t; messed up in
            Windows builds.
    -   Issue #111 follow-ons:
        -   Fixed initial time-signature drawing in data pane.
        -   Fixed errors in inserting a time-signature.
        -   Added a pulse (tick) calculator to iterate through
            time-signatures.
    -   Fixed an important port-translation bug in output port-mapping.
    -   Revamped the Playlist tab, as it was confusing and very buggy.
    -   Added auto-play and auto-advance to play-lists.
    -   Issue #102: Added Windows key-mapping to fix processing
        "native virtual" keys, such as the arrow keys.
Read the NEWS, README.md, and TODO files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants