Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: root source file in progress message #92

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Conversation

aherrmann
Copy link
Owner

The progress message of a zig_binary|library|test build did not always display the correct root source file. For example, on targets with package dependencies one of the package dependencies' source file was listed instead.

This change fixes that by enforcing a preorder on the action inputs.

  • Analysis test for progress message with package
  • fix: set inputs order to preorder

This ensures that the main source file is the first input and that the
progress message refers to the correct root module.
@aherrmann aherrmann enabled auto-merge June 24, 2023 10:38
@aherrmann aherrmann disabled auto-merge June 24, 2023 10:38
@aherrmann aherrmann enabled auto-merge June 24, 2023 10:38
@aherrmann aherrmann merged commit d4054f1 into main Jun 24, 2023
@aherrmann aherrmann deleted the progress-message branch June 24, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant