feat: Support ABI selection and transition #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazelbuild/platforms does not include such constraints. So, we define them here.
aherrmann
added a commit
that referenced
this pull request
May 10, 2024
This is reportedly the lowest glibc version number that Zig's own standard library supports, see https://github.com/ziglang/zig/blob/0.12.0/lib/libc/glibc/README.md?plain=1#L33-L34. Note, users can configure their own glibc version, see #169. Without this change the test at `//zig/runfiles:test` failed on the BuildBuddy default remote execution Docker image with an error of the form ``` /buildbuddy/remotebuilds/ace1eb7e-d203-470d-978b-3e7634972e45/bazel-out/k8-fastbuild/bin/zig/runfiles/test.runfiles/_main/zig/runfiles/test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /buildbuddy/remotebuilds/ace1eb7e-d203-470d-978b-3e7634972e45/bazel-out/k8-fastbuild/bin/zig/runfiles/test.runfiles/_main/zig/runfiles/test) ``` BREAKING CHANGE: The default glibc version is now pinned at 2.17.
aherrmann
added a commit
that referenced
this pull request
May 10, 2024
This is reportedly the lowest glibc version number that Zig's own standard library supports, see https://github.com/ziglang/zig/blob/0.12.0/lib/libc/glibc/README.md?plain=1#L33-L34. Note, users can configure their own glibc version, see #169. Without this change the test at `//zig/runfiles:test` failed on the BuildBuddy default remote execution Docker image with an error of the form ``` /buildbuddy/remotebuilds/ace1eb7e-d203-470d-978b-3e7634972e45/bazel-out/k8-fastbuild/bin/zig/runfiles/test.runfiles/_main/zig/runfiles/test: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /buildbuddy/remotebuilds/ace1eb7e-d203-470d-978b-3e7634972e45/bazel-out/k8-fastbuild/bin/zig/runfiles/test.runfiles/_main/zig/runfiles/test) ``` BREAKING CHANGE: The default glibc version is now pinned at 2.17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABI (libc type and version) is taken from the ABI component of the target triple. Hence, no real additional support is required. The existing target selection support is sufficient.
However, Bazel's bazelbuild/platforms does not capture ABI constraints. Therefore, we add an ABI constraint setting and constraint values to rules_zig. Note, that users do not necessarily have to use these. If needed they can define their own ABI constraint setting and values and define and register toolchains using these targets.
The default ABI was previously left undeclared in the toolchain declarations. This is changed to default to GNU on Linux and Windows and none on MacOS. Previously, Zig would default to musl on Linux, which is not a bad choice in general, but causes issues when trying to combine Zig generated binaries with Bazel built C/C++ binaries. If users want to use musl then they can do so by explicitly configuring a target platform that sets the musl abi constraint.
Closes #54
Closes #55