Skip to content

Commit

Permalink
[ci][build] fix vllm-flash-attn (vllm-project#8699)
Browse files Browse the repository at this point in the history
  • Loading branch information
youkaichao authored and agt committed Sep 24, 2024
1 parent 1a07370 commit f50f725
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,9 @@ endif()
# Set the parent build flag so that the vllm-flash-attn library does not redo compile flag and arch initialization.
set(VLLM_PARENT_BUILD ON)

# Ensure the vllm/vllm_flash_attn directory exists before installation
install(CODE "file(MAKE_DIRECTORY \"\${CMAKE_INSTALL_PREFIX}/vllm/vllm_flash_attn\")" COMPONENT vllm_flash_attn_c)

# Make sure vllm-flash-attn install rules are nested under vllm/
install(CODE "set(CMAKE_INSTALL_LOCAL_ONLY FALSE)" COMPONENT vllm_flash_attn_c)
install(CODE "set(OLD_CMAKE_INSTALL_PREFIX \"\${CMAKE_INSTALL_PREFIX}\")" COMPONENT vllm_flash_attn_c)
Expand Down
15 changes: 15 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,21 @@ def build_extensions(self) -> None:
]
subprocess.check_call(install_args, cwd=self.build_temp)

def run(self):
# First, run the standard build_ext command to compile the extensions
super().run()

# copy vllm/vllm_flash_attn/*.py from self.build_lib to current
# directory so that they can be included in the editable build
import glob
files = glob.glob(
os.path.join(self.build_lib, "vllm", "vllm_flash_attn", "*.py"))
for file in files:
dst_file = os.path.join("vllm/vllm_flash_attn",
os.path.basename(file))
print(f"Copying {file} to {dst_file}")
self.copy_file(file, dst_file)


def _no_device() -> bool:
return VLLM_TARGET_DEVICE == "empty"
Expand Down
Empty file added vllm/vllm_flash_attn/.gitkeep
Empty file.

0 comments on commit f50f725

Please sign in to comment.