-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use settings from trio for Selector waker socketpair #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure how to test this, also needs a changelog entry |
agronholm
approved these changes
Dec 16, 2024
mkjpryor
pushed a commit
to azimuth-cloud/azimuth
that referenced
this pull request
Jan 7, 2025
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [anyio](https://github.com/agronholm/anyio) from 4.7.0 to 4.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/agronholm/anyio/releases">anyio's releases</a>.</em></p> <blockquote> <h2>4.8.0</h2> <ul> <li>Added <strong>experimental</strong> support for running functions in subinterpreters on Python 3.13 and later</li> <li>Added support for the <code>copy()</code>, <code>copy_into()</code>, <code>move()</code> and <code>move_into()</code> methods in <code>anyio.Path</code>, available in Python 3.14</li> <li>Changed <code>TaskGroup</code> on asyncio to always spawn tasks non-eagerly, even if using a task factory created via <code>asyncio.create_eager_task_factory()</code>, to preserve expected Trio-like task scheduling semantics (PR by <a href="https://github.com/agronholm"><code>@agronholm</code></a> and <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Configure <code>SO_RCVBUF</code>, <code>SO_SNDBUF</code> and <code>TCP_NODELAY</code> on the selector thread waker socket pair (this should improve the performance of <code>wait_readable()</code> and <code>wait_writable()</code> when using the <code>ProactorEventLoop</code>) (<a href="https://redirect.github.com/agronholm/anyio/pull/836">#836</a>; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed <code>AssertionError</code> when using <code>nest-asyncio</code> (<a href="https://redirect.github.com/agronholm/anyio/issues/840">#840</a>)</li> <li>Fixed return type annotation of various context managers' <code>__exit__</code> method (<a href="https://redirect.github.com/agronholm/anyio/issues/847">#847</a>; PR by <a href="https://github.com/Enegg"><code>@Enegg</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/agronholm/anyio/blob/master/docs/versionhistory.rst">anyio's changelog</a>.</em></p> <blockquote> <h1>Version history</h1> <p>This library adheres to <code>Semantic Versioning 2.0 <http://semver.org/></code>_.</p> <p><strong>4.8.0</strong></p> <ul> <li>Added <strong>experimental</strong> support for running functions in subinterpreters on Python 3.13 and later</li> <li>Added support for the <code>copy()</code>, <code>copy_into()</code>, <code>move()</code> and <code>move_into()</code> methods in <code>anyio.Path</code>, available in Python 3.14</li> <li>Changed <code>TaskGroup</code> on asyncio to always spawn tasks non-eagerly, even if using a task factory created via <code>asyncio.create_eager_task_factory()</code>, to preserve expected Trio-like task scheduling semantics (PR by <a href="https://github.com/agronholm"><code>@agronholm</code></a> and <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Configure <code>SO_RCVBUF</code>, <code>SO_SNDBUF</code> and <code>TCP_NODELAY</code> on the selector thread waker socket pair (this should improve the performance of <code>wait_readable()</code>) and <code>wait_writable()</code> when using the <code>ProactorEventLoop</code> (<code>[#836](agronholm/anyio#836) <https://github.com/agronholm/anyio/pull/836></code>_; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed <code>AssertionError</code> when using <code>nest-asyncio</code> (<code>[#840](agronholm/anyio#840) <https://github.com/agronholm/anyio/issues/840></code>_)</li> <li>Fixed return type annotation of various context managers' <code>__exit__</code> method (<code>[#847](agronholm/anyio#847) <https://github.com/agronholm/anyio/issues/847></code>_; PR by <a href="https://github.com/Enegg"><code>@Enegg</code></a>)</li> </ul> <p><strong>4.7.0</strong></p> <ul> <li>Updated <code>TaskGroup</code> to work with asyncio's eager task factories (<code>[#764](agronholm/anyio#764) <https://github.com/agronholm/anyio/issues/764></code>_)</li> <li>Added the <code>wait_readable()</code> and <code>wait_writable()</code> functions which will accept an object with a <code>.fileno()</code> method or an integer handle, and deprecated their now obsolete versions (<code>wait_socket_readable()</code> and <code>wait_socket_writable()</code>) (PR by <a href="https://github.com/davidbrochart"><code>@davidbrochart</code></a>)</li> <li>Changed <code>EventAdapter</code> (an <code>Event</code> with no bound async backend) to allow <code>set()</code> to work even before an async backend is bound to it (<code>[#819](agronholm/anyio#819) <https://github.com/agronholm/anyio/issues/819></code>_)</li> <li>Added support for <code>wait_readable()</code> and <code>wait_writable()</code> on <code>ProactorEventLoop</code> (used on asyncio + Windows by default)</li> <li>Fixed a misleading <code>ValueError</code> in the context of DNS failures (<code>[#815](agronholm/anyio#815) <https://github.com/agronholm/anyio/issues/815></code>_; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed the return type annotations of <code>readinto()</code> and <code>readinto1()</code> methods in the <code>anyio.AsyncFile</code> class (<code>[#825](agronholm/anyio#825) <https://github.com/agronholm/anyio/issues/825></code>_)</li> <li>Fixed <code>TaskInfo.has_pending_cancellation()</code> on asyncio returning false positives in cleanup code on Python >= 3.11 (<code>[#832](agronholm/anyio#832) <https://github.com/agronholm/anyio/issues/832></code>_; PR by <a href="https://github.com/gschaffner"><code>@gschaffner</code></a>)</li> <li>Fixed cancelled cancel scopes on asyncio calling <code>asyncio.Task.uncancel</code> when propagating a <code>CancelledError</code> on exit to a cancelled parent scope (<code>[#790](agronholm/anyio#790) <https://github.com/agronholm/anyio/pull/790></code>_; PR by <a href="https://github.com/gschaffner"><code>@gschaffner</code></a>)</li> </ul> <p><strong>4.6.2</strong></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/anyio/commit/74022ec53cde6c2e5d7441de37d5a0dcf9d6daad"><code>74022ec</code></a> Bumped up the version</li> <li><a href="https://github.com/agronholm/anyio/commit/264a6f9f911ebd5a6b7d9d79dfa4bf91ac5d8ceb"><code>264a6f9</code></a> Added support for subinterpreter workers (<a href="https://redirect.github.com/agronholm/anyio/issues/850">#850</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/6d612a9fbd037352507209543bc8dde6462f62d6"><code>6d612a9</code></a> Refactored waiting for tasks to complete from task group on the asyncio backe...</li> <li><a href="https://github.com/agronholm/anyio/commit/8b7a5352aec2c0cdd2f9a991da601f2f5b22cf8b"><code>8b7a535</code></a> Removed the unwarranted gc_collect fixture</li> <li><a href="https://github.com/agronholm/anyio/commit/acdac7abf59761a77e17738abfabbda9dea68ad7"><code>acdac7a</code></a> Changed TaskGroup to always spawn tasks lazily, even with eager task factorie...</li> <li><a href="https://github.com/agronholm/anyio/commit/43e1f5fd133b2f53993d606af207b06a0d09fecc"><code>43e1f5f</code></a> Fixed <code>__exit__()</code> return type of various context managers (<a href="https://redirect.github.com/agronholm/anyio/issues/849">#849</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/e8730ae116aa924b0386fef15dcb3a7c15490283"><code>e8730ae</code></a> Added preliminary support for Python 3.14 (<a href="https://redirect.github.com/agronholm/anyio/issues/813">#813</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/9a792f3568f450ad97363d7bf0baa04f768ae291"><code>9a792f3</code></a> Pruned unnecessary mypy options</li> <li><a href="https://github.com/agronholm/anyio/commit/2a105b2bc6ebb4d12b67b4c9c1777ff5cc54f42b"><code>2a105b2</code></a> Updated downstream test workflow</li> <li><a href="https://github.com/agronholm/anyio/commit/3f8c639d36d0ac01d341b25f6f99f1bc7aff6d12"><code>3f8c639</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/agronholm/anyio/issues/846">#846</a>)</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/anyio/compare/4.7.0...4.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=anyio&package-manager=pip&previous-version=4.7.0&new-version=4.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mkjpryor
pushed a commit
to azimuth-cloud/cluster-api-addon-provider
that referenced
this pull request
Jan 15, 2025
Bumps [anyio](https://github.com/agronholm/anyio) from 4.7.0 to 4.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/agronholm/anyio/releases">anyio's releases</a>.</em></p> <blockquote> <h2>4.8.0</h2> <ul> <li>Added <strong>experimental</strong> support for running functions in subinterpreters on Python 3.13 and later</li> <li>Added support for the <code>copy()</code>, <code>copy_into()</code>, <code>move()</code> and <code>move_into()</code> methods in <code>anyio.Path</code>, available in Python 3.14</li> <li>Changed <code>TaskGroup</code> on asyncio to always spawn tasks non-eagerly, even if using a task factory created via <code>asyncio.create_eager_task_factory()</code>, to preserve expected Trio-like task scheduling semantics (PR by <a href="https://github.com/agronholm"><code>@agronholm</code></a> and <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Configure <code>SO_RCVBUF</code>, <code>SO_SNDBUF</code> and <code>TCP_NODELAY</code> on the selector thread waker socket pair (this should improve the performance of <code>wait_readable()</code> and <code>wait_writable()</code> when using the <code>ProactorEventLoop</code>) (<a href="https://redirect.github.com/agronholm/anyio/pull/836">#836</a>; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed <code>AssertionError</code> when using <code>nest-asyncio</code> (<a href="https://redirect.github.com/agronholm/anyio/issues/840">#840</a>)</li> <li>Fixed return type annotation of various context managers' <code>__exit__</code> method (<a href="https://redirect.github.com/agronholm/anyio/issues/847">#847</a>; PR by <a href="https://github.com/Enegg"><code>@Enegg</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/agronholm/anyio/blob/master/docs/versionhistory.rst">anyio's changelog</a>.</em></p> <blockquote> <h1>Version history</h1> <p>This library adheres to <code>Semantic Versioning 2.0 <http://semver.org/></code>_.</p> <p><strong>4.8.0</strong></p> <ul> <li>Added <strong>experimental</strong> support for running functions in subinterpreters on Python 3.13 and later</li> <li>Added support for the <code>copy()</code>, <code>copy_into()</code>, <code>move()</code> and <code>move_into()</code> methods in <code>anyio.Path</code>, available in Python 3.14</li> <li>Changed <code>TaskGroup</code> on asyncio to always spawn tasks non-eagerly, even if using a task factory created via <code>asyncio.create_eager_task_factory()</code>, to preserve expected Trio-like task scheduling semantics (PR by <a href="https://github.com/agronholm"><code>@agronholm</code></a> and <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Configure <code>SO_RCVBUF</code>, <code>SO_SNDBUF</code> and <code>TCP_NODELAY</code> on the selector thread waker socket pair (this should improve the performance of <code>wait_readable()</code>) and <code>wait_writable()</code> when using the <code>ProactorEventLoop</code> (<code>[#836](agronholm/anyio#836) <https://github.com/agronholm/anyio/pull/836></code>_; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed <code>AssertionError</code> when using <code>nest-asyncio</code> (<code>[#840](agronholm/anyio#840) <https://github.com/agronholm/anyio/issues/840></code>_)</li> <li>Fixed return type annotation of various context managers' <code>__exit__</code> method (<code>[#847](agronholm/anyio#847) <https://github.com/agronholm/anyio/issues/847></code>_; PR by <a href="https://github.com/Enegg"><code>@Enegg</code></a>)</li> </ul> <p><strong>4.7.0</strong></p> <ul> <li>Updated <code>TaskGroup</code> to work with asyncio's eager task factories (<code>[#764](agronholm/anyio#764) <https://github.com/agronholm/anyio/issues/764></code>_)</li> <li>Added the <code>wait_readable()</code> and <code>wait_writable()</code> functions which will accept an object with a <code>.fileno()</code> method or an integer handle, and deprecated their now obsolete versions (<code>wait_socket_readable()</code> and <code>wait_socket_writable()</code>) (PR by <a href="https://github.com/davidbrochart"><code>@davidbrochart</code></a>)</li> <li>Changed <code>EventAdapter</code> (an <code>Event</code> with no bound async backend) to allow <code>set()</code> to work even before an async backend is bound to it (<code>[#819](agronholm/anyio#819) <https://github.com/agronholm/anyio/issues/819></code>_)</li> <li>Added support for <code>wait_readable()</code> and <code>wait_writable()</code> on <code>ProactorEventLoop</code> (used on asyncio + Windows by default)</li> <li>Fixed a misleading <code>ValueError</code> in the context of DNS failures (<code>[#815](agronholm/anyio#815) <https://github.com/agronholm/anyio/issues/815></code>_; PR by <a href="https://github.com/graingert"><code>@graingert</code></a>)</li> <li>Fixed the return type annotations of <code>readinto()</code> and <code>readinto1()</code> methods in the <code>anyio.AsyncFile</code> class (<code>[#825](agronholm/anyio#825) <https://github.com/agronholm/anyio/issues/825></code>_)</li> <li>Fixed <code>TaskInfo.has_pending_cancellation()</code> on asyncio returning false positives in cleanup code on Python >= 3.11 (<code>[#832](agronholm/anyio#832) <https://github.com/agronholm/anyio/issues/832></code>_; PR by <a href="https://github.com/gschaffner"><code>@gschaffner</code></a>)</li> <li>Fixed cancelled cancel scopes on asyncio calling <code>asyncio.Task.uncancel</code> when propagating a <code>CancelledError</code> on exit to a cancelled parent scope (<code>[#790](agronholm/anyio#790) <https://github.com/agronholm/anyio/pull/790></code>_; PR by <a href="https://github.com/gschaffner"><code>@gschaffner</code></a>)</li> </ul> <p><strong>4.6.2</strong></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/anyio/commit/74022ec53cde6c2e5d7441de37d5a0dcf9d6daad"><code>74022ec</code></a> Bumped up the version</li> <li><a href="https://github.com/agronholm/anyio/commit/264a6f9f911ebd5a6b7d9d79dfa4bf91ac5d8ceb"><code>264a6f9</code></a> Added support for subinterpreter workers (<a href="https://redirect.github.com/agronholm/anyio/issues/850">#850</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/6d612a9fbd037352507209543bc8dde6462f62d6"><code>6d612a9</code></a> Refactored waiting for tasks to complete from task group on the asyncio backe...</li> <li><a href="https://github.com/agronholm/anyio/commit/8b7a5352aec2c0cdd2f9a991da601f2f5b22cf8b"><code>8b7a535</code></a> Removed the unwarranted gc_collect fixture</li> <li><a href="https://github.com/agronholm/anyio/commit/acdac7abf59761a77e17738abfabbda9dea68ad7"><code>acdac7a</code></a> Changed TaskGroup to always spawn tasks lazily, even with eager task factorie...</li> <li><a href="https://github.com/agronholm/anyio/commit/43e1f5fd133b2f53993d606af207b06a0d09fecc"><code>43e1f5f</code></a> Fixed <code>__exit__()</code> return type of various context managers (<a href="https://redirect.github.com/agronholm/anyio/issues/849">#849</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/e8730ae116aa924b0386fef15dcb3a7c15490283"><code>e8730ae</code></a> Added preliminary support for Python 3.14 (<a href="https://redirect.github.com/agronholm/anyio/issues/813">#813</a>)</li> <li><a href="https://github.com/agronholm/anyio/commit/9a792f3568f450ad97363d7bf0baa04f768ae291"><code>9a792f3</code></a> Pruned unnecessary mypy options</li> <li><a href="https://github.com/agronholm/anyio/commit/2a105b2bc6ebb4d12b67b4c9c1777ff5cc54f42b"><code>2a105b2</code></a> Updated downstream test workflow</li> <li><a href="https://github.com/agronholm/anyio/commit/3f8c639d36d0ac01d341b25f6f99f1bc7aff6d12"><code>3f8c639</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/agronholm/anyio/issues/846">#846</a>)</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/anyio/compare/4.7.0...4.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=anyio&package-manager=pip&previous-version=4.7.0&new-version=4.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Lifted from https://github.com/python-trio/trio/blob/da89ae850658fb365064cb12a47659c8a0ac44b5/src/trio/_core/_wakeup_socketpair.py#L12
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/
) added which would fail without your patchdocs/
, in case of behavior changes or newfeatures)
docs/versionhistory.rst
).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**
as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.