Skip to content

Commit

Permalink
pybamm-team#3428 rename all instances of "plating" to "lithium-metal …
Browse files Browse the repository at this point in the history
…electrode"
  • Loading branch information
agriyakhetarpal committed Oct 9, 2023
1 parent ae7dc73 commit 92e2a4f
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pybamm/input/parameters/lithium_ion/Mohtat2020.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def get_parameter_values():
"chemistry": "lithium_ion",
# lithium plating
"Lithium metal partial molar volume [m3.mol-1]": 1.3e-05,
"Exchange-current density for plating [A.m-2]": 0.001,
"Exchange-current density for lithium-metal electrode [A.m-2]": 0.001,
"Initial plated lithium concentration [mol.m-3]": 0.0,
"Typical plated lithium concentration [mol.m-3]": 1000.0,
"Lithium plating transfer coefficient": 0.7,
Expand Down
2 changes: 1 addition & 1 deletion pybamm/input/parameters/lithium_ion/OKane2022.py
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ def get_parameter_values():
# lithium plating
"Lithium metal partial molar volume [m3.mol-1]": 1.3e-05,
"Lithium plating kinetic rate constant [m.s-1]": 1e-09,
"Exchange-current density for plating [A.m-2]"
"Exchange-current density for lithium-metal electrode [A.m-2]"
"": plating_exchange_current_density_OKane2020,
"Exchange-current density for stripping [A.m-2]"
"": stripping_exchange_current_density_OKane2020,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def get_parameter_values():
# lithium plating
"Lithium metal partial molar volume [m3.mol-1]": 1.3e-05,
"Lithium plating kinetic rate constant [m.s-1]": 1e-09,
"Exchange-current density for plating [A.m-2]"
"Exchange-current density for lithium-metal electrode [A.m-2]"
"": plating_exchange_current_density_OKane2020,
"Exchange-current density for stripping [A.m-2]"
"": stripping_exchange_current_density_OKane2020,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/parameters/lithium_ion_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,14 @@ def j0_stripping(self, c_e, c_Li, T):
)

def j0_plating(self, c_e, c_Li, T):
"""Dimensional exchange-current density for plating [A.m-2]"""
"""Dimensional exchange-current density for lithium-metal electrode [A.m-2]"""
inputs = {
"Electrolyte concentration [mol.m-3]": c_e,
"Plated lithium concentration [mol.m-3]": c_Li,
"Temperature [K]": T,
}
return pybamm.FunctionParameter(
"Exchange-current density for plating [A.m-2]", inputs
"Exchange-current density for lithium-metal electrode [A.m-2]", inputs
)

def dead_lithium_decay_rate(self, L_sei):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ def test_functions(self):

fun_test = {
# Lithium plating
"Exchange-current density for plating [A.m-2]": ([1e3, 1e4, T], 9.6485e-2),
"Exchange-current density for lithium-metal electrode [A.m-2]": (
[1e3, 1e4, T], 9.6485e-2
),
"Exchange-current density for stripping [A.m-2]": (
[1e3, 1e4, T],
9.6485e-1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ def test_functions(self):

fun_test = {
# Lithium plating
"Exchange-current density for plating [A.m-2]": ([1e3, 1e4, T], 9.6485e-2),
"Exchange-current density for lithium-metal electrode [A.m-2]": (
[1e3, 1e4, T], 9.6485e-2
),
"Exchange-current density for stripping [A.m-2]": (
[1e3, 1e4, T],
9.6485e-1,
Expand Down

0 comments on commit 92e2a4f

Please sign in to comment.