Skip to content

Commit

Permalink
split voltage maximum and minumum from voltages used to calculate sto…
Browse files Browse the repository at this point in the history 
…ich windows for 0 and 100% SOC
  • Loading branch information
@js1tr3
js1tr3 committed Dec 16, 2022
1 parent d3bdea9 commit 465c45f
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 26 deletions.
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Ai2020.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 3.0,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 3.0,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 3.0,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 24108.0,
"Initial concentration in positive electrode [mol.m-3]": 21725.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Chen2020.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.5,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.5,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.5,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 29866.0,
"Initial concentration in positive electrode [mol.m-3]": 17038.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Chen2020_composite.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.5,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.5,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.5,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 29866.0,
"Initial concentration in positive electrode [mol.m-3]": 17038.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Ecker2015.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.5,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.5,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.5,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 26120.05,
"Initial concentration in positive electrode [mol.m-3]": 12630.8,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Marquis2019.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 3.105,
"Upper voltage cut-off [V]": 4.1,
"Open circuit potential at 0% [V]": 3.105,
"Open circuit potential at 0% SOC [V]": 4.1,
"Open circuit potential at 0% SOC [V]": 3.105,
"Open circuit potential at 100% SOC [V]": 4.1,
"Initial concentration in negative electrode [mol.m-3]": 19986.609595075,
"Initial concentration in positive electrode [mol.m-3]": 30730.7554385565,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Mohtat2020.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.8,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.8,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.8,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 48.8682,
"Initial concentration in positive electrode [mol.m-3]": 31513.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/NCA_Kim2011.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.7,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.7,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.7,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 18081.0,
"Initial concentration in positive electrode [mol.m-3]": 20090.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/OKane2022.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.5,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.5,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.5,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 29866.0,
"Initial concentration in positive electrode [mol.m-3]": 17038.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/ORegan2022.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1037,8 +1037,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.5,
"Upper voltage cut-off [V]": 4.4,
"Open circuit potential at 0% [V]": 2.5,
"Open circuit potential at 0% SOC [V]": 4.4,
"Open circuit potential at 0% SOC [V]": 2.5,
"Open circuit potential at 100% SOC [V]": 4.4,
"Initial concentration in negative electrode [mol.m-3]": 28866.0,
"Initial concentration in positive electrode [mol.m-3]": 13975.0,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Prada2013.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.0,
"Upper voltage cut-off [V]": 4.4,
"Open circuit potential at 0% [V]": 2.0,
"Open circuit potential at 0% SOC [V]": 4.4,
"Open circuit potential at 0% SOC [V]": 2.0,
"Open circuit potential at 100% SOC [V]": 4.4,
"Initial concentration in negative electrode [mol.m-3]": 28831.45783,
"Initial concentration in positive electrode [mol.m-3]": 35.3766672,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Ramadass2004.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 2.8,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 2.8,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 2.8,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in negative electrode [mol.m-3]": 22610.7,
"Initial concentration in positive electrode [mol.m-3]": 25777.5,
"Initial temperature [K]": 298.15,
Expand Down
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/Xu2019.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ def get_parameter_values():
"Number of cells connected in series to make a battery": 1.0,
"Lower voltage cut-off [V]": 3.5,
"Upper voltage cut-off [V]": 4.2,
"Open circuit potential at 0% [V]": 3.5,
"Open circuit potential at 0% SOC [V]": 4.2,
"Open circuit potential at 0% SOC [V]": 3.5,
"Open circuit potential at 100% SOC [V]": 4.2,
"Initial concentration in positive electrode [mol.m-3]": 4631.0,
"Initial temperature [K]": 298.15,
# citations
Expand Down
4 changes: 2 additions & 2 deletions pybamm/parameters/electrical_parameters.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def _set_dimensional_parameters(self):
self.voltage_high_cut_dimensional = pybamm.Parameter(
"Upper voltage cut-off [V]"
)
self.opc_soc_0_dimensional = pybamm.Parameter("Open circuit potential at 0% [V]")
self.opc_soc_0_dimensional = pybamm.Parameter("Open circuit potential at 0% SOC [V]")
self.opc_soc_100_dimensional = pybamm.Parameter(
"Open circuit potential at 0% SOC [V]"
"Open circuit potential at 100% SOC [V]"
)
# Current as a function of *dimensional* time. The below is overwritten in
# lithium_ion_parameters.py and lead_acid_parameters.py to use the correct
Expand Down

0 comments on commit 465c45f

Please sign in to comment.