Skip to content

Commit

Permalink
Revert "pybamm-team#3480 Install CMake alongside nox and skip `py…
Browse files Browse the repository at this point in the history
…bamm-requires`"

This reverts commit 2da613d.
  • Loading branch information
agriyakhetarpal committed Dec 16, 2023
1 parent 9118c2b commit 44ce67e
Showing 1 changed file with 14 additions and 22 deletions.
36 changes: 14 additions & 22 deletions .github/workflows/test_on_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,10 @@ jobs:
python-version: ${{ matrix.python-version }}
cache: 'pip'

- name: Install nox and CMake
run: python -m pip install nox cmake
- name: Install nox
run: python -m pip install nox

- name: Cache pybamm-requires nox environment for GNU/Linux and macOS
id: pybamm-requires
uses: actions/cache@v3
if: matrix.os != 'windows-latest'
with:
Expand All @@ -109,7 +108,7 @@ jobs:
key: nox-${{ matrix.os }}-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py', '**/noxfile.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux and macOS
if: matrix.os != 'windows-latest' && steps.pybamm-requires.outputs.cache-hit != 'true'
if: matrix.os != 'windows-latest'
run: python -m nox -s pybamm-requires

- name: Run unit tests for ${{ matrix.os }} with Python ${{ matrix.python-version }}
Expand Down Expand Up @@ -148,11 +147,10 @@ jobs:
python-version: 3.11
cache: 'pip'

- name: Install nox and CMake
run: python -m pip install nox cmake
- name: Install nox
run: python -m pip install nox

- name: Cache pybamm-requires nox environment for GNU/Linux
id: pybamm-requires
uses: actions/cache@v3
with:
path: |
Expand All @@ -165,7 +163,6 @@ jobs:
key: nox-${{ matrix.os }}-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py', '**/noxfile.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: steps.pybamm-requires.outputs.cache-hit != 'true'
run: python -m nox -s pybamm-requires

- name: Run unit tests for Ubuntu with Python 3.11 and generate coverage report
Expand Down Expand Up @@ -230,11 +227,10 @@ jobs:
python-version: ${{ matrix.python-version }}
cache: 'pip'

- name: Install nox and CMake
run: python -m pip install nox cmake
- name: Install nox
run: python -m pip install nox

- name: Cache pybamm-requires nox environment for GNU/Linux and macOS
id: pybamm-requires
uses: actions/cache@v3
if: matrix.os != 'windows-latest'
with:
Expand All @@ -248,7 +244,7 @@ jobs:
key: nox-${{ matrix.os }}-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py', '**/noxfile.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux and macOS
if: matrix.os != 'windows-latest' && steps.pybamm-requires.outputs.cache-hit != 'true'
if: matrix.os != 'windows-latest'
run: python -m nox -s pybamm-requires

- name: Run integration tests for ${{ matrix.os }} with Python ${{ matrix.python-version }}
Expand All @@ -275,11 +271,11 @@ jobs:
execute_install_scripts: true

# dot -c is for registering graphviz fonts and plugins
- name: Install TeXLive for Linux
- name: Install OpenBLAS and TeXLive for Linux
run: |
sudo apt-get update
sudo dot -c
sudo apt-get install texlive-latex-extra dvipng
sudo apt-get install libopenblas-dev texlive-latex-extra dvipng
- name: Set up Python 3.11
id: setup-python
Expand Down Expand Up @@ -330,11 +326,10 @@ jobs:
python-version: 3.11
cache: 'pip'

- name: Install nox and CMake
run: python -m pip install nox cmake
- name: Install nox
run: python -m pip install nox

- name: Cache pybamm-requires nox environment for GNU/Linux
id: pybamm-requires
uses: actions/cache@v3
with:
path: |
Expand All @@ -347,7 +342,6 @@ jobs:
key: nox-${{ matrix.os }}-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py', '**/noxfile.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: steps.pybamm-requires.outputs.cache-hit != 'true'
run: python -m nox -s pybamm-requires

- name: Run example notebooks tests for GNU/Linux with Python 3.11
Expand Down Expand Up @@ -386,11 +380,10 @@ jobs:
python-version: 3.11
cache: 'pip'

- name: Install nox and CMake
run: python -m pip install nox cmake
- name: Install nox
run: python -m pip install nox

- name: Cache pybamm-requires nox environment for GNU/Linux
id: pybamm-requires
uses: actions/cache@v3
with:
path: |
Expand All @@ -403,7 +396,6 @@ jobs:
key: nox-${{ matrix.os }}-pybamm-requires-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/install_KLU_Sundials.py', '**/noxfile.py') }}

- name: Install SuiteSparse and SUNDIALS on GNU/Linux
if: steps.pybamm-requires.outputs.cache-hit != 'true'
run: python -m nox -s pybamm-requires

- name: Run example scripts tests for GNU/Linux with Python 3.11
Expand Down

0 comments on commit 44ce67e

Please sign in to comment.