Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
  • Loading branch information
arjxn-py and Saransh-cpp authored Jun 18, 2023
1 parent 961a6be commit 1aa8b8a
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import sys


@nox.session(name="pybamm-requires")
@nox.session(name="pybamm-requires", reuse_venv=True)
def run_pybamm_requires(session):
homedir = os.getenv("HOME")
session.env["SUNDIALS_INST"] = session.env.get("SUNDIALS_INST", f"{homedir}/.local")
Expand All @@ -22,7 +22,7 @@ def run_pybamm_requires(session):
)


@nox.session(name="coverage")
@nox.session(name="coverage", reuse_venv=True)
def run_coverage(session):
homedir = os.getenv("HOME")
session.env["SUNDIALS_INST"] = session.env.get("SUNDIALS_INST", f"{homedir}/.local")
Expand All @@ -46,7 +46,7 @@ def run_integration(session):
session.env[
"LD_LIBRARY_PATH"
] = f"{homedir}/.local/lib:{session.env.get('LD_LIBRARY_PATH')}"
session.run("pip", "install", "-e", ".")
session.run("pip", "install", "-e", ".[dev]")
if sys.platform == "linux":
session.install("scikits.odes")
session.run("python", "run-tests.py", "--integration")
Expand Down Expand Up @@ -111,16 +111,7 @@ def run_tests(session):
@nox.session(name="docs", reuse_venv=True)
def build_docs(session):
envbindir = session.bin
session.run("pip", "install", "-e", ".")
session.install(
"sphinx>=1.5",
"pydata-sphinx-theme",
"sphinx-autobuild",
"sphinx_design",
"sphinx-copybutton",
"myst-parser",
"sphinx-inline-tabs",
)
session.run("pip", "install", "-e", ".[docs]")
session.chdir("docs/")
session.run(
"sphinx-autobuild", "--open-browser", "-qT", ".", f"{envbindir}/../tmp/html"
Expand Down

0 comments on commit 1aa8b8a

Please sign in to comment.