Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilities type limits #70

Closed
nathankota opened this issue Aug 24, 2022 · 3 comments · Fixed by #82, #83, #84, #85 or #86
Closed

Facilities type limits #70

nathankota opened this issue Aug 24, 2022 · 3 comments · Fixed by #82, #83, #84, #85 or #86
Assignees
Labels
enhancement New feature or request

Comments

@nathankota
Copy link

There is currently a "Limit to UDOT Facilities" button for the Road and Active Transportation project types.

I believe this draws upon a single attribute that is binary...each project is either attributed as a UDOT road or Local facility

Our long range planning staff would like to have the current 'Limit to UDOT Facilities' option and an option to 'Limit to Local Facilities.

This could possible be done similarly to what I had mocked up yesterday for the Limit to Needs [<|=] FC enhancement, wherein in this additional enhancement, there is, similarly, a check box to enable Limit to [UDOT|Local] Facilities with a hover for info/click to toggle between the two options.

@nathankota nathankota added the enhancement New feature or request label Aug 24, 2022
@stdavis stdavis self-assigned this Aug 25, 2022
@stdavis
Copy link
Member

stdavis commented Aug 25, 2022

@BGranberg or @msilski:
Would these queries work for this new control?

Limit to UDOT Facilities: lower(breakout) LIKE '%udot%'
Limit to local Facilities: lower(breakout) LIKE '%local%'

These, of course, would be configurable. I'm thinking that the config would look something like this:

"Limit to {option} Facilities": {
  "field": "breakout",
  "labels": ["UDOT", "local"],
  "values": ["udot", "local"],
  "offByDefault": true,
  "useAnd": true
}

@msilski
Copy link
Contributor

msilski commented Aug 29, 2022

The issue with this is that the attributes for the breakout column for the Roadway and Active Transportation project types can be State, Local, or State/Local. I'm not sure how to resolve this last, mixed category.

I think the desired behavior would be for the Limit to UDOT Facilities control to show State AND State/Local; the Limit to Local Facilities control would show Local AND State/Local.

Limit to UDOT Facilities: lower(breakout) LIKE '%state%'
Limit to Local Facilities: lower(breakout) LIKE '%local%'

So the two controls would not be mutually exclusive. Would that work?

@stdavis
Copy link
Member

stdavis commented Aug 30, 2022

Yes, that looks great. I got udot mixed up with state in my example queries. I'm working on this currently...

stdavis added a commit that referenced this issue Sep 2, 2022
BREAKING CHANGE: A new filter config property, `limitFacilityType`, has been added. Also, the `useAnd` and `offByDefault` options have been removed since they are no longer needed.

Also, contains some layout improvements in UsePhasing to match the new LimitFacilityType widget.

Closes #70
This was referenced Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment