Skip to content

Commit

Permalink
docs: make it clear that you can pass a project id or alias
Browse files Browse the repository at this point in the history
  • Loading branch information
stdavis committed Oct 31, 2024
1 parent 33c293d commit 203a2b0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
6 changes: 6 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"cSpell.words": [
"prebuild",
"worknote"
]
}
18 changes: 9 additions & 9 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ inputs:
description: Service Account Email
required: true
project-id:
description: Project ID
description: Project ID or alias. This also sets the firebase environment (https://firebase.google.com/docs/functions/config-env).
required: true
preview:
description: Determines if firebase deploys to a preview channel
Expand Down Expand Up @@ -71,7 +71,7 @@ runs:
create_credentials_file: true

- name: 🍳 Run prebuild command
if: ${{ inputs.prebuild-command != '' }}
if: inputs.prebuild-command != ''
shell: bash
run: ${{ inputs.prebuild-command }}

Expand All @@ -88,6 +88,12 @@ runs:
${{ runner.OS }}-bower-
${{ runner.OS }}
- name: ❓ Determining if preview should be created
id: should-create-preview
if: inputs.preview == 'yes'
shell: bash
run: echo "deploy=yes" >> $GITHUB_OUTPUT

- name: 🪣 Cache firebase
uses: actions/cache@v4
with:
Expand All @@ -97,12 +103,6 @@ runs:
${{ runner.OS }}-firebase-
${{ runner.OS }}-
- name: ❓ Determining if preview should be created
id: should-create-preview
if: inputs.preview == 'yes'
shell: bash
run: echo "deploy=yes" >> $GITHUB_OUTPUT

- name: 🚀 Firebase deploy preview
id: deploy
if: steps.should-create-preview.outputs.deploy == 'yes'
Expand All @@ -124,7 +124,7 @@ runs:
- name: 🔔 Publish deployment worknote
uses: agrc/service-now-worknote-action@v1
if: ${{ inputs.service-now-system-id != '' && inputs.preview != 'yes' }}
if: inputs.service-now-system-id != '' && inputs.preview != 'yes'
with:
repo-token: ${{ inputs.repo-token }}
username: ${{ inputs.service-now-username }}
Expand Down

0 comments on commit 203a2b0

Please sign in to comment.