Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust compiler options with "Rust 1.66.0 (2021)" #315

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

davidmcnamee
Copy link
Contributor

Hi, I just noticed the VSCode extension wasn't working for Rust submissions to Codeforces... I think it's because Codeforces uses a newer Rust compiler than what the extension currently supports. This is my first PR, so let me know if there's anything else you'd like me to change/test, or if there's a better way to get this patch upstream.

I took the ID from this page, where I found this in the raw html:
<option value="75" selected="selected">Rust 1.66.0 (2021)</option>. The previous rust compiler ("Rust 1.42.0") is no longer an option on the Codeforces site.

Testing

tested by running vsce package and installing locally. It submitted this Rust program successfully:
image

Also the automated tests seem to pass:

$ npm run test

> competitive-programming-helper@5.9.2 pretest
> tsc -p ./


> competitive-programming-helper@5.9.2 test
> jest out/

 PASS  out/tests/utilsPure.test.js
 PASS  out/tests/judge.test.js

Test Suites: 2 passed, 2 total
Tests:       7 passed, 7 total
Snapshots:   0 total
Time:        1.095 s

@davidmcnamee
Copy link
Contributor Author

I was a bit too quick to open this PR; here's an issue that describes the bug #316

Copy link
Owner

@agrawal-d agrawal-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@agrawal-d agrawal-d merged commit f445fd0 into agrawal-d:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants