Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizer debug builds #35

Open
wants to merge 2 commits into
base: Agoric
Choose a base branch
from
Open

Sanitizer debug builds #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6174078
enable sanitizers controlled by envvar
raphdev Feb 24, 2023
ef596c0
ubsan check arch compatibility
raphdev Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions xsnap/makefiles/lin/xsnap-worker.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ NAME = xsnap-worker
ifneq ($(VERBOSE),1)
MAKEFLAGS += --silent
endif
ARCH := $(shell uname -m)

# MODDABLE = $(CURDIR)/../../moddable
BUILD_DIR = $(CURDIR)/../../build
Expand Down Expand Up @@ -49,8 +50,36 @@ C_OPTIONS = \
C_OPTIONS += \
-Wno-misleading-indentation \
-Wno-implicit-fallthrough

LINK_OPTIONS = -rdynamic

ifeq ($(GOAL),debug)
C_OPTIONS += -g -O0 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
C_OPTIONS += -g -O1 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
ifeq ($(SANITIZER), memory)
C_OPTIONS += -fsanitize=memory
LINK_OPTIONS += -fsanitize=memory

# add origin tracking, it adds additional perf cost on top of msan
ifdef MSAN_TRACK_ORIGINS
C_OPTIONS += -fsanitize-memory-track-origins
endif
endif

ifeq ($(SANITIZER), address)
C_OPTIONS += -fsanitize=address -fsanitize-recover=address
LINK_OPTIONS += -fsanitize=address -fsanitize-recover=address
endif

ifeq ($(SANITIZER), undefined)
C_OPTIONS += -fsanitize=bool,builtin,enum,float-divide-by-zero,integer-divide-by-zero,null,object-size,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr -fno-sanitize-recover=bool,builtin,enum,float-divide-by-zero,integer-divide-by-zero,null,object-size,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr -fsanitize-recover=undefined
LINK_OPTIONS += -fsanitize=bool,builtin,enum,float-divide-by-zero,integer-divide-by-zero,null,object-size,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr -fno-sanitize-recover=bool,builtin,enum,float-divide-by-zero,integer-divide-by-zero,null,object-size,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr -fsanitize-recover=undefined

# function and other ubsan checks not available in some arch, such as arm
ifneq ($(ARCH), aarch64)
C_OPTIONS += -fsanitize=array-bounds,function,unsigned-integer-overflow
LINK_OPTIONS += -fsanitize=array-bounds,function,unsigned-integer-overflow
endif
endif
else
C_OPTIONS += -O3
endif
Expand All @@ -62,8 +91,6 @@ ifeq ($(XSNAP_RANDOM_INIT),1)
C_OPTIONS += -DmxSnapshotRandomInit
endif

LINK_OPTIONS = -rdynamic

OBJECTS = \
$(TMP_DIR)/xsAll.o \
$(TMP_DIR)/xsAPI.o \
Expand Down