fix: Revert "fix: halt-height behavior is not deterministic (#305)" #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b8423a. This commit caused test failures in agoric-sdk. Reverting to land other changes in agoric-sdk. We'll restore the change and try to debug the failure against a smaller diff in the future.
JimLarson
changed the title
|
Anticipating an immediate tag. |
|
Weird golangci-lint failure. Ugh. |
mhofman
reviewed
Nov 9, 2023
CHANGELOG-Agoric.md
Outdated
| @@ -45,4 +51,3 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| ### Bug Fixes | |||
|
|
|||
| * (snapshots) [#304](https://github.com/agoric-labs/cosmos-sdk/pull/304) raise the per snapshot item limit. Fixes [Agoric/agoric-sdk#8325](https://github.com/Agoric/agoric-sdk/issues/8325) | |||
| * (baseapp) [#305](https://github.com/agoric-labs/cosmos-sdk/pull/305) Make sure we don't execute blocks beyond the halt height. Port of [cosmos/cosmos-sdk#16639](https://github.com/cosmos/cosmos-sdk/pull/16639) | |||
There was a problem hiding this comment.
We probably shouldn't delete this entry
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs Agoric/agoric-sdk#8223
Refs Agoric/agoric-sdk#8326
Revert #305 which causes test failure in Agoric/agoric-sdk.
Author Checklist
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change