*: change gateway runs api #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alessandro-sorint Feel free to test/review it and report your feedback. |
* Don't expose the runservice run id. In future, if needed, we should choose how to generate it considering if we want to shard to multiple runservices. * The gateway exposed runs are now per project/user (direct runs) and not global and referenced by the project/user reference plus the run number. So the gateway will only accept requests targeting a specific project/user. * Also notification commit status will use the run number (it already also use the project id). This will break current commit status links that uses instead the run id since there's no more gateway api to fetch a run by id.
sgotti
force-pushed
the
gateway_make_runs_api_related_to_project_user
branch
from
0dc3da1
to
788554a
Compare
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…ated_to_project_user *: change gateway runs api
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…ated_to_project_user *: change gateway runs api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't expose the runservice run id. In future, if needed, we should
choose how to generate it considering if we want to shard to multiple
runservices.
The gateway exposed runs are now per project/user (direct runs) and
not global and referenced by the project/user reference plus the run
number. So the gateway will only accept requests targeting a specific
project/user.
Also notification commit status will use the run number (it already
also use the project id). This will break current commit status links
that uses instead the run id since there's no more gateway api to
fetch a run by id.
Implements #310
Related agola-web PR: agola-io/agola-web#62