Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test TestRun/panic_fails in Windows #59

Open
agnivade opened this issue May 3, 2024 · 10 comments · Fixed by #63 or #66
Open

Flaky test TestRun/panic_fails in Windows #59

agnivade opened this issue May 3, 2024 · 10 comments · Fixed by #63 or #66
Labels
bug Something isn't working

Comments

@agnivade
Copy link
Owner

agnivade commented May 3, 2024

=== RUN   TestRun/panic_fails
=== PAUSE TestRun/panic_fails
=== RUN   TestRun/panic_in_next_run_of_event_loop_fails
=== PAUSE TestRun/panic_in_next_run_of_event_loop_fails
=== CONT  TestRun/panic_in_next_run_of_event_loop_fails
=== CONT  TestRun/panic_fails
    main_test.go:73: Unexpected error message: "exit with status 2" != "websocket url timeout reached"
=== NAME  TestRun/panic_in_next_run_of_event_loop_fails
    main_test.go:73: Unexpected error message: "context canceled" != "websocket url timeout reached"
--- FAIL: TestRun (0.00s)
    --- FAIL: TestRun/panic_fails (24.93s)
    --- FAIL: TestRun/panic_in_next_run_of_event_loop_fails (24.93s)
@agnivade agnivade added the bug Something isn't working label May 3, 2024
@hajimehoshi
Copy link
Contributor

We have a very similar issue hajimehoshi/ebiten#2982

@hajimehoshi
Copy link
Contributor

https://pkg.go.dev/github.com/chromedp/chromedp#WSURLReadTimeout

Would it be possible to adjust the timeout?

@agnivade
Copy link
Owner Author

agnivade commented May 7, 2024

Hmm .. the default value seems 20 seconds which should be more than enough. I could increase it, but it would just push the goal post. I wonder if there's a deeper problem here.

@agnivade
Copy link
Owner Author

Re-ran tests multiple times with the associated PR. Looks like the problem is gone now.

@agnivade
Copy link
Owner Author

Well, no. It fails in master. Reopening, and skipping the test on Windows for now.

@hajimehoshi
Copy link
Contributor

Apparently the issue was resolved. Thank you very much!

@hajimehoshi
Copy link
Contributor

@agnivade
Copy link
Owner Author

agnivade commented Aug 9, 2024

Go 1.19 is quite old. I am not 100% if that plays any role or not, but I only test with supported Go releases.

@hajimehoshi
Copy link
Contributor

Sure, I'll let you know when the same thing happens with the supported Go releases...

@agnivade
Copy link
Owner Author

Reopening again.

@agnivade agnivade reopened this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants