Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPI CONFIG: Disable UART explicitly, fixes #567 #568

Closed
wants to merge 6 commits into from
Closed

RPI CONFIG: Disable UART explicitly, fixes #567 #568

wants to merge 6 commits into from

Conversation

myfreescalewebpage
Copy link

- What I did

Explicitly set "enable_uart=0" when the console is disabled.

- How I did it

Modify rpi-config recipe.

@agherzan-ci
Copy link

Can one of the admins verify this patch?

@myfreescalewebpage
Copy link
Author

Added explicit disable as discussed with @agherzan
Also update doc (let me known if the text is ok for you).

@agherzan
Copy link
Owner

@agherzan-ci ok to test

@myfreescalewebpage
Copy link
Author

Merged master in my branch to allow merge of the PR.

@myfreescalewebpage
Copy link
Author

@agherzan any news here ?

@agherzan
Copy link
Owner

agherzan commented Feb 6, 2020

@myfreescalewebpage can you please squash the commits? We ended up with two commits and a merge one. Let's have only one on top of current HEAD.

commit 7c1d3ce
Author: MyFreescaleWebPage <myfreescalewebpage@free.fr>
Date:   Wed Jan 29 23:20:43 2020 +0100

    RPI CONFIG: Explicitly indicate if UART should be disabled

commit 1150d86
Author: MyFreescaleWebPage <myfreescalewebpage@free.fr>
Date:   Mon Jan 20 22:09:14 2020 +0100

    RPI CONFIG: Disable UART fix
@myfreescalewebpage
Copy link
Author

Sorry for the delay.
I'm not sure of the current commit... I'm not a git expert on this, maybe you can assist me because I don't know how and why doing this. Thanks!

@agherzan
Copy link
Owner

gIt rebase -i and squash all the bits.

@myfreescalewebpage
Copy link
Author

Miss up with my git, deleted and created again this PR at #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants