Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better product change #749

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Better product change #749

merged 3 commits into from
Sep 12, 2023

Conversation

imobachgs
Copy link
Contributor

Problem

Follow-up of #747.

When handling a product change, the manager raises an exception and sets the service as idle.

Solution

  • Do not raise an exception, just check whether it is possible to handle the product change.
  • Do not change the product if it is not really changed.

@imobachgs imobachgs merged commit 9c310af into agama-project:master Sep 12, 2023
7 checks passed
@imobachgs imobachgs deleted the better-product-change branch September 12, 2023 13:58
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imobachgs @dgdavid