Mark more texts for translation #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
commented
Aug 28, 2023
| isStack | ||
| label={ | ||
| format( | ||
| n_("Choose a product (%d available)", "Choose a product (%d available)", products.length), |
There was a problem hiding this comment.
Here I'm not sure if we really need to display the number of available products.
- There are usually just few products
- The number does not provide any meaningful information for the user, you can always choose only one product, it does not matter how many products are available
So I'd rather make it easier and use just simple _("Choose a product") here.
Opinions?
There was a problem hiding this comment.
Yes, I agree, I would get rid of the number of available products.
imobachgs
approved these changes
Aug 28, 2023
jreidinger
reviewed
Aug 28, 2023
| @@ -88,16 +89,18 @@ function ProductSelectionPage() { | |||
|
|
|||
| return ( | |||
| <> | |||
| <Title>Product selection</Title> | |||
| {/* TRANSLATORS: page header */} | |||
| <Title>{_("Product selection")}</Title> | |||
There was a problem hiding this comment.
not sure if in title it should not be all capitalized like Product Selection
There was a problem hiding this comment.
Why? Do we have any guidelines about that?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just marking more texts for translation